Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

weekly-digest · 2020-02-16T06:38:28Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 204 issues were created.
Of these, 112 issues have been closed and 92 issues are still open.

OPEN ISSUES

💚 #38052 Clean up splints usage, by Ramza13
💚 #38051 Option override support for tests, by jbytheway
💚 #38049 Crash on start when SCALING_FACTOR option is 2 or 4, by drfloob
💚 #38048 Trench Knife is now an unarmed weapon, by Hymore246
💚 #38047 change uncraft recipe for sandbag, and fix component quantity, by NastyNate2612
💚 #38046 [WIP] Tweak mapgen for animal pound, by arijust
💚 #38044 Add -Wmissing-noreturn, and add attributes, by jbytheway
💚 #38043 Overrun tweaks, by RarkGrames
💚 #38042 Add spoilage to reconstituted protein shakes, by pjf
💚 #38041 The "common cold" is very unreasonable implemented, by AncientSion
💚 #38038 Cougars leap into deep water and drown, by Funguss
💚 #38036 River meets lake bad mapgen, by Funguss
💚 #38034 Failed attempts to descend from a single story rooftop deal the same damage as stepping or leaping from a single story rooftop., by SpadeDraco
💚 #38033 Update Spike and Makeshift Knife recipe to be more reasonable., by Xenomorph-III
💚 #38030 [CR] [WIP] Clean up and organize item info panel, by wapcaplet
💚 #38028 Crafted item components dont seem stacked in disassemble window, by Shibimon
💚 #38027 Auto-drive fails for boats, by Funguss
💚 #38026 encapsulate item::contents, by KorGgenT
💚 #38025 Magiclysm Old Magus quest crash, by Funguss
💚 #38024 Autosave makes different program the focus, by TheGamingFox1911
💚 #38023 Filter mask cartridge exploit, by Shibimon
💚 #38022 move has_rotten_away from map to item, by KorGgenT
💚 #38020 Clean some exothermic CBM code, by Fris0uman
💚 #38018 Lighting a smoking rack with a camp fire drill consumes no time, by l29ah
💚 #38015 Deadened mutation: inconsistent prevention of showing limb health values, by GGgatherer
💚 #38014 'E'at menu doesn't stay open on last item, by Break-Off
💚 #38013 Secondary experience, by roaringjohn
💚 #38008 Error while butchering while too far from corpse, by bug-sniper
💚 #38007 The json linter has broken wrapping behaviour, by imayhaveborkedit
💚 #38006 Grammar/Spelling, by klorpa
💚 #38005 Chemical Revolution: Chemistry Skill and Lithium, by roaringjohn
💚 #38000 Animal Pound building has bad placement feature., by AncientSion
💚 #37997 Control laptop's IFF protocol override is too tedious to use, by l29ah
💚 #37995 Uncanny Dodge spends too much energy on dodge, by GGgatherer
💚 #37994 PASGT and better helmets, by TheGamingFox1911
💚 #37992 Refactor pathfinding_settings constructor arguments, by jkraybill
💚 #37991 [WIP]Magiclysm: summon vehicle spell : floating disk, by davidpwbrown
💚 #37985 Labs contain fungal furniture and terrain in worlds with No_Fungi mod active, by randomTechneck
💚 #37984 Collapsible requirements breakdown toggle in recipe menu, by Soup-de-Loop
💚 #37982 NPC training display bug, by Funguss
💚 #37980 Option to remove auto-generated number shortcuts from various item menus, by WeaverThree
💚 #37979 Migrate/obsolete incongruent Leadworks, EBR, and Rivtech guns, by tenmillimaster
💚 #37978 Specify avoid_sharp for appropriate monsters, by jkraybill
💚 #37977 Uninterrupted Sleep on Death, by Willenbrink
💚 #37974 Fix remote vehicles teleporting when folding, by saurocyte
💚 #37971 Vehicle construction and destruction time, by Funguss
💚 #37970 Vehicle construction does not accept wire, by Funguss
💚 #37969 'Red stone' can contain items, by Funguss
💚 #37968 Auto-travel doesn't update the map memory, by l29ah
💚 #37965 Fix cow milking from cows from old saves with old milk not raw milk., by davidpwbrown
💚 #37961 Survivor armor rework, by RarkGrames
💚 #37959 Extracts and Concentrates pt 6 (recipes), by NastyNate2612
💚 #37956 Extracts and Concentrates pt 5, by NastyNate2612
💚 #37955 Hold your breath, by Funguss
💚 #37953 Safe speed colouring for target speed, by Funguss
💚 #37952 Smoking rack caused meat to rot, by Funguss
💚 #37951 Additional map features doesn't respect visibility, by Funguss
💚 #37949 Actors rarely cross Z levels, by Funguss
💚 #37947 Mutinous fish et al, by Funguss
💚 #37946 extracts and concentrates pt4, by NastyNate2612
💚 #37945 Preoccupied enemies, by Funguss
💚 #37944 extracts and concentrates pt2, by NastyNate2612
💚 #37943 Fuel remaining wildly inaccurate, by Funguss
💚 #37942 Extracts and Concentrates pt 3, by NastyNate2612
💚 #37937 Game uses bugged font on first start, by Hirmuolio
💚 #37936 Extracts and Concentrates pt 1, by NastyNate2612
💚 #37935 [WIP]Hot air balloons, by davidpwbrown
💚 #37930 Indian cookbook, by ashGlaw
💚 #37929 Zombie ball and Corpse beetle., by arijust
💚 #37927 Handle FILTHY tag when unloading/reloading items, by ZhilkinSerg
💚 #37925 Splint usability, by jkraybill
💚 #37920 Examining a bathtub or other receptacle should not immediately ask what to fill it with, by jkraybill
💚 #37919 Fix font loading, by ZhilkinSerg
💚 #37917 Add kefir or fermented milk into the game, by Kenan2000
💚 #37916 Game fails to display non-latin alphabet characters possibly due to PR #37668, by VoidForge
💚 #37912 Recover hunter and trapper jobs display twice in camp job list, by DavisBroda
💚 #37911 changre npc::mug_player to not use item index, by KorGgenT
💚 #37910 migrate player_activity using item index to item_location, by KorGgenT
💚 #37908 WIP [Aftershock] Frankenstein NPCs, by Maleclypse
💚 #37906 Survivor (and all other) gas masks needs encumbrance rebalance, by Pspiotrek
💚 #37905 Update documentation of seed_data and also document disinfectant_power, by snipercup
💚 #37899 Cows from older saves come with milk, not milk_raw, leading to errors, by jeremyshannon
💚 #37895 Can specify delay in emit_fields for monsters, by Fris0uman
💚 #37894 Window manager for properly refreshing and resizing multiple layers of windows, by Qrox
💚 #37874 Reloading Glass Jars of Sugar, by Karthas077
💚 #37869 Rework Character Generation, by ifreund
💚 #37865 Add map_bash_info to fields , by Fris0uman
💚 #37860 Impossible to remove freshly installed foot pedals: Remove attached part first., by l29ah
💚 #37856 Mapgen sometimes generates completely empty towns, by l29ah
💚 #37852 Add script for simple local testing of website with docker, by ifreund
💚 #37850 WIP Quantum solar panel to [Aftershock], by Maleclypse
💚 #37847 Wasted components in recipes with alternatives, by Karthas077

CLOSED ISSUES

LIKED ISSUE

👍 #37935 [WIP]Hot air balloons, by davidpwbrown
It received 👍 x8, 😄 x0, 🎉 x3 and ❤️ x3.

NOISY ISSUE

🔈 #37869 Rework Character Generation, by ifreund
It received 69 comments.

PULL REQUESTS

Last week, 179 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 3 pull requests were opened.
💚 #38048 Trench Knife is now an unarmed weapon, by Hymore246
💚 #38046 [WIP] Tweak mapgen for animal pound, by arijust
💚 #37852 Add script for simple local testing of website with docker, by ifreund

UPDATED PULL REQUEST

Last week, 64 pull requests were updated.
💛 #38047 change uncraft recipe for sandbag, and fix component quantity, by NastyNate2612
💛 #38044 Add -Wmissing-noreturn, and add attributes, by jbytheway
💛 #38043 Overrun tweaks, by RarkGrames
💛 #38042 Add spoilage to reconstituted protein shakes, by pjf
💛 #38033 Update Spike and Makeshift Knife recipe to be more reasonable., by Xenomorph-III
💛 #38022 move has_rotten_away from map to item, by KorGgenT
💛 #38020 Clean some exothermic CBM code, by Fris0uman
💛 #38006 Grammar/Spelling, by klorpa
💛 #38005 Chemical Revolution: Chemistry Skill and Lithium, by roaringjohn
💛 #37994 PASGT and better helmets, by TheGamingFox1911
💛 #37991 [WIP]Magiclysm: summon vehicle spell : floating disk, by davidpwbrown
💛 #37979 Migrate/obsolete incongruent Leadworks, EBR, and Rivtech guns, by tenmillimaster
💛 #37974 Fix remote vehicles teleporting when folding, by saurocyte
💛 #37965 Fix cow milking from cows from old saves with old milk not raw milk., by davidpwbrown
💛 #37959 Extracts and Concentrates pt 6 (recipes), by NastyNate2612
💛 #37956 Extracts and Concentrates pt 5, by NastyNate2612
💛 #37946 extracts and concentrates pt4, by NastyNate2612
💛 #37944 extracts and concentrates pt2, by NastyNate2612
💛 #37942 Extracts and Concentrates pt 3, by NastyNate2612
💛 #37936 Extracts and Concentrates pt 1, by NastyNate2612
💛 #37935 [WIP]Hot air balloons, by davidpwbrown
💛 #37930 Indian cookbook, by ashGlaw
💛 #37929 Zombie ball and Corpse beetle., by arijust
💛 #37927 Handle FILTHY tag when unloading/reloading items, by ZhilkinSerg
💛 #37919 Fix font loading, by ZhilkinSerg
💛 #37911 changre npc::mug_player to not use item index, by KorGgenT
💛 #37910 migrate player_activity using item index to item_location, by KorGgenT
💛 #37908 WIP [Aftershock] Frankenstein NPCs, by Maleclypse
💛 #37895 Can specify delay in emit_fields for monsters, by Fris0uman
💛 #37894 Window manager for properly refreshing and resizing multiple layers of windows, by Qrox
💛 #37865 Add map_bash_info to fields , by Fris0uman
💛 #37850 WIP Quantum solar panel to [Aftershock], by Maleclypse
💛 #37839 Fix missing mapgen keys, by jbytheway
💛 #37827 Working laptops, by RarkGrames
💛 #37816 change item_location return from an int to item_location, by KorGgenT
💛 #37806 Add The Satanic Bible, by Karthas077
💛 #37804 Allow delete and extend qualities in item definitions, by ZhilkinSerg
💛 #37798 Remove quantum solar panels, by ymber
💛 #37782 Crazy Cataclysm - Adds a Zombie Hulk wearing a funny hat, by genessee596
💛 #37715 Dynamic compact aim window pt.1, by Kilvoctu
💛 #37710 Update explosives to use corrrect explosive power, casing mass, and fragment mass., by Brian-Otten
💛 #37660 WIP [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession, by Maleclypse
💛 #37599 Tool belt rework, by RarkGrames
💛 #37582 [WIP][CR] Adding vitamins and toxin levels monitor functions to Blood Analyser CBM, by eilaattwood
💛 #37578 Refluff power armour and adjust stats slightly, by I-am-Erk
💛 #37577 Throwing knife bandolier, by ashGlaw
💛 #37552 Use text snippets for tutorial messages, by ZhilkinSerg
💛 #37497 WIP: Initial Blazemod re-work, by Soup-de-Loop
💛 #37453 Jsonize vehicle parts requiring other vehicle parts to be installed, by Hirmuolio
💛 #37314 Allow professions to start with a nearby vehicle - trucker profession, by davidpwbrown
💛 #37300 [WIP]NPC work log - for debugging and feedback, by davidpwbrown
💛 #37263 WIP Autolearn recipes rework cooking part 1, by Maleclypse
💛 #37241 Rebalance archery take... 5?, by kevingranade
💛 #37052 Explosives disassembly, by Brian-Otten
💛 #36959 added batch time saving for all sugar recipes, by 8ctopus
💛 #36862 increase kcal spent walking with carry weight, by KorGgenT
💛 #36853 Military armor balance, by Brian-Otten
💛 #36543 Auto eat and drink from auto-zones during long activities/waiting, by davidpwbrown
💛 #36074 Add "forbidden traits" to professions , by np-vortex
💛 #35540 [WIP]Framework for out-of-reality-bubble NPC activities 1:foraging, by davidpwbrown
💛 #34690 [WIP]Towing vehicles, by davidpwbrown
💛 #33829 Flyable Helicopters, by davidpwbrown
💛 #33556 CRIT Expansion Update [WIP], by Soupster89
💛 #32012 [WIP] Fix 3d shadowcasting, by ifreund

MERGED PULL REQUEST

COMMITS

Last week there were 171 commits.
🛠️ Remove bubble car spawns (#38050) Minireactor powered vehicles haven't fit in canon fore a while, so they
shouldn't be spawning.
Have them spawn in Aftershock instead. by anothersimulacrum
🛠️ Add commit activity badge by ifreund
🛠️ [Lower time needed for hard_tack recipe. (#37993) * Lower time needed for hard_tack recipe.

Raise time for recipe from 45 min to 75 min.](eac228d) by arijust
🛠️ Merge pull request #38040 from snipercup/armor-name-to-object Armor name to object, fix looks_like, volume to string by ZhilkinSerg
🛠️ Merge pull request #38039 from snipercup/Comestible-name-to-object Comestible name to object by ZhilkinSerg
🛠️ Armor name to object, fix looks_like, volume to string by snipercup
🛠️ Merge pull request #38037 from snipercup/Armor-name-to-object Armor Name to object, volume to string by ZhilkinSerg
🛠️ Comestible name to object by snipercup
🛠️ Name to object, volume to string by snipercup
🛠️ [Improve discoverability of cddatags (Improve discoverability of cddatags #37954) * Mention cddatags in the JSON docs
Strip platform-specific path separator for tags

This is fixing a hypothetical bug which I think cddatags would have
suffered from on Windows (but untested there).

Use cddatags in Makefile

There were already two rules for creating tags; update them both.

Move some cddatags docs to DEVELOPER_TOOLING

The second paragraph was not useful to non-code-writing contributors, so
move it and rewrite it.

cddatags: Force UTF-8 encoding for json files
Expand on the cddatags docs

This makes mp3 players take the same amount of time to activate or
deactivate as music-playing smartphones.

PR #37584 added 200 (de-)activation time to the smartphones, but
since the mp3 player already had its own 200 move cost, this made the
mp3 player take twice as long as the other devices.

Mention music instead of earbuds in message

Previous message was vague

Fixes #37996](04d9e0f) by wapcaplet
🛠️ Merge pull request #38009 from I-am-Erk/ultica-13-02-2020 13 Feb 2020 Ultimate Cataclysm Demo Update by ZhilkinSerg
🛠️ Fix astyle regression by ZhilkinSerg
🛠️ 13 feb 2020 ultimate cataclysm demo update by I-am-Erk
🛠️ [Generic modern json (#38004) * Name to object, volume to string

Name to object, volume to string](6c50a8c) by snipercup
🛠️ Add the option to display ascii art in item description (#37598) by Fris0uman
🛠️ Mapgen fixes for non-blacklisted mods (#37845) by ZhilkinSerg
🛠️ [Expand and improve iteminfo_tests (Expand and improve iteminfo_tests #37823) * Add tests for basic info, conductivity, qualities

Tests item info for description, category, volume, weight, qualities and
conductivity.

Enhance and clean up iteminfo tests

Include price and material in basic info test; refactor armor_info tests
into one test case with two sections. All passing.

Add weapon, repairability, and flags

Includes tests for:

Weapon attack rating and mvoes
Techniques when wielded
Repairability and with what tools
Item description flags

Add missing brace and fix brace style
Expand ranged weapon and food spoilage tests

Using compound bow to test:

reload time
firing mode
weapon mods

Using pine nuts to test:

freshness/spoiled indicator

Remove longshirt repair test

This test fails with the magiclysm mod loaded, since it inserts
"enchanted tailor's kit" into the repair options. Since it's not
essential, I simply took it out for now.

Remove trailing space

Co-Authored-By: Isaac Freund [email protected]

Disable lint for reload time test

Co-Authored-By: Isaac Freund [email protected]

Ensure consistent spoilage estimate in test

item.cpp#L934 get_freshness_description gives more detailed rot
estimation messages to more skilled characters. Travis-CI revealed this
test failing sometimes; this commit should ensure a consistent (0) skill
level when testing these messages.

Co-authored-by: Isaac Freund [email protected]](2c81f50) by wapcaplet
🛠️ [Aftershock] Prepnet dialogue and itemgroup fixes (#37950) by Maleclypse
🛠️ Support pathfinding avoiding sharp objects (barbed wire etc) (#37964) by jkraybill
🛠️ JSONize mending modifier from mutations (#37987) The effect mutations have on limb mending was hardcoded in a if/else
ladder. Yuck! Also, some of the slow healer mutations were not having
an impact on mending speed, so add that. by anothersimulacrum
🛠️ Fix auto attack to handle lighting and glass better (#37983) by Ramza13
🛠️ Merge pull request #37989 from CleverRaven/doc-vcpkg-2020-02-13 Update COMPILING-VS-VCPKG.md by ZhilkinSerg
🛠️ Update mutations.json (#37883) Change good and bad memory traits have changed to match the new skill rust system by wingbrother
🛠️ Merge pull request #37981 from Kilvoctu/ui-hotkeys-fix Fix ui hotkey help not updating by ZhilkinSerg
🛠️ Generic modern json (#37999) by snipercup
🛠️ Ammo name to object (#38002) by snipercup
🛠️ Merge pull request #38001 from snipercup/Comestible-name-to-object Comestible Name to object by ZhilkinSerg
🛠️ Name to object by snipercup
🛠️ Updating magazine_well for the regular UPS Increasing from 1L to 1.5L in order to account for increased volume of all heavy batteries by ektoplazm
🛠️ Update COMPILING-VS-VCPKG.md by ZhilkinSerg
🛠️ Merge pull request #37893 from ifreund/submap-encapsulation Improve submap encapsulation by Rivet-the-Zombie
🛠️ Merge pull request #37988 from Kilvoctu/panel-test-fix Fix clang-tidy error with panels.cpp by ZhilkinSerg
🛠️ Add line to fix test by Kilvoctu
🛠️ Fix hotkey help not updating by Kilvoctu
🛠️ [Abandon camp fix (#37976) * use different pos as random NPC can be invalidated

remove random guy](b9b3901) by davidpwbrown
🛠️ Merge pull request #37973 from Kilvoctu/remove-duplicate-sound-label-sidebar-option Fix duplicate sound display for labels sidebar by ZhilkinSerg
🛠️ Merge pull request #37972 from snipercup/Tool_armor-gun-monster-name-to-object Tool_armor, gun and monster name to object by ZhilkinSerg
🛠️ Generic, bionic_item modern json (#37975) by snipercup
🛠️ Format bug report template comments as such (#37963) To avoid meaningless repetitive editing. by l29ah
🛠️ fix Repairs like balclava (#37967) by snipercup
🛠️ Tool_armor gun monster name to object by snipercup
🛠️ move (labels) sound out of needs by Kilvoctu
🛠️ Merge pull request #37966 from snipercup/Gun-name-to-object-leave-the-s Gun-name-to-object-leave-the-s by ZhilkinSerg
🛠️ Allow meat scraps as ingredient in meat sandwiches (#37958) by bug-sniper
🛠️ Gun-name-to-object-leave-the-s by snipercup
🛠️ Expand looks_like for terrain (#37957) by I-am-Erk
🛠️ Merge pull request #37886 from CleverRaven/fix-DBZ-2020-02-10 Prevent potential DBZ in vehicle smash code by Rivet-the-Zombie
🛠️ Gun name to object (#37941) by snipercup
🛠️ add last basements (#37948) by curstwist
🛠️ add more basic basements (#37940) by curstwist
🛠️ houses for legacy basements (#37939) by curstwist
🛠️ [Change food recipes in minor ways to improve utelization of ingredients (Change food recipes in minor ways to improve utelization of ingredients #37604) * Add boiled fiddleheads to any_veggy

Fiddleheads should be more well integrated into the game. I've added them to any_veggy and removed the ability to boil fiddleheads in broth to avoid recursion errors

Update cooking_components.json

Added a requirement list including cooking oils and butter, because many recipes should work fine with any of them

Added new list to pancakes recipe for testing

So I can test the "any_butter_or_oil" requirement I swapped out the cooking oils for it

cooking_oil1 isn't a thing >__<
lint
Tests Past. Cake recipe time

I ran a simple test, seeing if I could craft pancakes with butter. Worked fine.

I'm gonna edit recipe_food.json next. Tests to follow

Added new cooking component: fry_oil

For when you want the food to absorb some of the fat it's being deep fried in. Potato chips and French fries both use fry_oil, which contains cooking_oil, cooking_oil2, and ghee. All tested. Works properly for me

Update recipe_food.json

Changed a bunch of recipes to use any_butter_or_oil. Tested each one. Seems to work fine

Fixed syntax error
Many minor changes to recipes

I made fried liver and fried tripe use fry_oil
Canged some pan frying oils to any_butter_or_oil
Added boiled and sauteed fiddleheads to salad recipe
Added salsify_baked to any_veggie

Took dandelion_cooked out of recipe because it's already in veggy_any
Update tile_config.json
Trying to pass tests
Update veggy_dishes.json

Co-authored-by: I-am-Erk [email protected]](36d1aa4) by ashGlaw
🛠️ Fix documentation typo by kevingranade
🛠️ [Changelog jan 2020 (#37881) * Ignore missing author login instead of crashing.

Import changelogs up to January 2020.
Copyedit changelog](d3788e1) by kevingranade
🛠️ Merge pull request #37923 from snipercup/Ammo-modern-json-2 Ammo Name to object leave the s, double have decimal by ZhilkinSerg
🛠️ 'Remove attached part first.' message displays the part name (#37922) by AMurkin
🛠️ Merge pull request #37932 from SeventhSandwich/map_management_doc_edit Fix typo on pages.h by ZhilkinSerg
🛠️ Merge pull request #37938 from Night-Pryanik/character-creation-menu-fix Tweaked description window x start point by ZhilkinSerg
🛠️ [Added recipe for ghee (Added recipe for ghee #37913) * Added recipe for ghee

I noticed we didn't have a ghee recipe, so I added one. It seemed similar to cooking_oil2 so I used that as a base. Should I add a rag to the components to represent straining through cheesecloth? Should it require a strainer?

Now you need a strainer of some sort. added a variety
Make craft time realistic

Co-Authored-By: I-am-Erk [email protected]

Added an indian cookbook, moved curry and ghee recipes to that

Tested and things seem to be working

Itemgroups added

The book should spawn in a number of different places now, with a fairly low distribution. Not married to those numbers, though

Set ghee recipe to be in cookbook
Removed Indian Cookbook from books, itemgroups, and recipes

Co-authored-by: I-am-Erk [email protected]](011455f) by ashGlaw
🛠️ Tweaked description window x start point by Night-Pryanik
🛠️ [add more basements (#37931) * add more basements

Update regional_map_settings.json](9b081aa) by curstwist
🛠️ Update pages.h fix typo by SeventhSandwich
🛠️ [Craft soapy water out of soap flakes (Craft soapy water out of soap flakes #37878) * Craft soapy water out of soap flakes

Add soap flakes as a componet for crafting soapy water.

Update recipe_medsandchemicals.json

Co-authored-by: I-am-Erk [email protected]](07d5448) by Cyrano7
🛠️ Update colors.json (#37854) by 8street
🛠️ Change hay into bale of hay (#37924) by arijust
🛠️ Name to object leave the s, double have decimal by snipercup
🛠️ Merge pull request #37898 from CleverRaven/fix-non-existent-ae Remove non-existing ammo effect from code by Rivet-the-Zombie
🛠️ [Add houses for existing basements (#37902) * add houses for existing basements

Update house30.json](4ab395e) by curstwist
🛠️ Merge pull request #37896 from mlangsdorf/visible_npc_attitude_change npc: only report attitude changes that the avatar can see by ZhilkinSerg
🛠️ Gun name to object (#37903) by snipercup
🛠️ Ammo modern json (#37909) by snipercup
🛠️ Comestible name to object (#37907) by snipercup
🛠️ Merge pull request #37914 from anothersimulacrum/scen-bl Clear loaded scenario blacklist when leaving world by ZhilkinSerg
🛠️ [Clear the screen after exiting from character creation UI (Clear the screen after exiting from character creation UI #37915) * Clear the screen after exiting from character creation UI

Also fixed small grahical glitch in skills tab in character creation menu

Refresh too](7572e38) by Night-Pryanik
🛠️ Adjust grenade values (#37585) by Brian-Otten
🛠️ Clear loaded scenario blacklist when leaving world This caused you to be unable to load a world with a mod containing a scenario blacklist more than once without exiting the game. Also don't locally redefine all_scenarios when finalizing scenario blacklists. by anothersimulacrum
🛠️ Don't add duplicate options to the page (#37548) by ZhilkinSerg
🛠️ Fix map memory edge case (#37460) by Trioct
🛠️ [Transfer inhaler to NPC inventory on mission end (Transfer inhaler to NPC inventory on mission end #37454) * Let asthmatic NPC keep inhaler after quest

I recruited an asthmatic NPC after completing their inhaler mission and
was startled to see they had already lost it. This allows them to keep
the inhaler you find for them.

Attempted fix for #31773. I have detailed some problems with this commit
in comments on that issue.

Not take away all the player's inhalers

This may be a case of the workaround being worse than what's being
worked around. Will find a better solution.

Don't sell inhaler by individual charges

When using this function to sell an inhaler to an NPC, u.has_charges
is (apparently) returning true (since player has inhaler charges),
although the inhaler itself is not counted by charges according to
@BevapDin.

This change makes set_u_sell_item follow more closely the pattern of
set_u_buy_item, by merging the two separate if/else blocks into one,
handling both the charge adjustment and p.i_add to transfer them item.

Most importantly, the first condition for doing charge-based adjustment
is whether count_by_charges() is true. I've preserved the check for
u.has_charges, because we need to ensure the requested number of
charges are available.](5a90688) by wapcaplet
🛠️ Allow user font dir by ZhilkinSerg
🛠️ Create CODEOWNERS file to alert mod maintainers to changes in their mods. (#37662) by I-am-Erk
🛠️ add more basements (#37900) by curstwist
🛠️ missedmigrations, riot bot, blacklist more, missed casings, (#37888) by tenmillimaster
🛠️ Merge pull request #37889 from CleverRaven/mod-sees-player-retrodays-plus Make sees player mod compatible with retrodays+ by Rivet-the-Zombie
🛠️ Remove non-existing ammo effect from code by ZhilkinSerg
🛠️ npc: only report attitude changes that the avatar can see Simple fix to stop the player from seeing attitude changes for NPCs that the avatar cannot see. by mlangsdorf
🛠️ Use static constexpr in class by ifreund
🛠️ Make submap privately inherit from maptile_soa There are still two loose ends on proper encapsulation here. Namely, the non-const get_field() and get_items(). These need to be replaced with either the necessary setters or by moving necessary code to submap. by ifreund
🛠️ Encapsulate trp by ifreund
🛠️ Partially encapsulate fld by ifreund
🛠️ Partially encapsulate itm by ifreund
🛠️ Encapsulate lum by ifreund
🛠️ Encapsulate frn by ifreund
🛠️ Encapsulate ter by ifreund
🛠️ Merge pull request #37891 from RarkGrames/Pasta-item-group-fix Food item group fix by ZhilkinSerg
🛠️ Merge pull request #37890 from RarkGrames/Vet-Survivor-Z-tweaks Vet Survivor Z drop tweaks by ZhilkinSerg
🛠️ Update food.json by RarkGrames
🛠️ Make sees player mod compatible with retrodays+ by ZhilkinSerg
🛠️ Merge pull request #37871 from Ramza13/auto_forage Fix dangerous pickups and auto forage not working together by ZhilkinSerg
🛠️ Merge pull request #37887 from snipercup/Gun-barrel-length-to-string Gun barrel length to string by ZhilkinSerg
🛠️ Gun barrel length to string by snipercup
🛠️ #37817 fix (#37884) by ZhilkinSerg
🛠️ Comestible name to object (#37885) by snipercup
🛠️ Fix possible DBZ in vehicle code by ZhilkinSerg
🛠️ Added tweaks by RarkGrames
🛠️ #37817 fix by jkraybill
🛠️ Fix shooter earmuff not deafening when off (#37876) by LaVeyanFiend
🛠️ [Add script to generate tags for CDDA json data (#37877) * Fix typo in keys.py

Add cddatags.py

This is a tool to augment a tags file with CDDA json tags, to allow for
easier navigation of the CDDA game data via standard text-editor
support.

For more on the tags file format:

http://ctags.sourceforge.net/FORMAT](https://github.com/CleverRaven/Cataclysm-DDA/commit/901eb71df1021b52ca87adfdcb9e1fa7ff31fec8) by jbytheway
🛠️ Name to object, leave the s (#37870) by snipercup
🛠️ [Add basements 3 (#37873) * crack house basements

basements for preppers, fortified
stair removals

one is a duplex and one has abandoned variant, needs further planning on basements for these types.

lint](1b61a64) by curstwist
🛠️ Remove binoculars from Bionic Sniper profession (#37880) Remove binoculars from Bionic Sniper profession by Cyrano7
🛠️ [add basements to house_garage series (add basements to house_garage series #37864) * add basements to house_garage series
Update house_garage8.json](60eb74e) by curstwist
🛠️ [Add basements 1 (Add basements 1 #37863) * add support entries
add basic basements detatched house series](1e58b1d) by curstwist
🛠️ [Generic name to object (Generic name to object #37868) * name to object leave the s, volume to string
Name to object](b660524) by snipercup
🛠️ Merge pull request #37872 from ifreund/astyle-reg Fix astyle regression by codemime
🛠️ Fix astyle regression by ifreund
🛠️ Use setting where needed by Ramza13
🛠️ Fix telescope eyes not preventing eye mutations (#37849) by Ramza13
🛠️ Fix typo in tainted blood description (#37853) by Drack820
🛠️ Fix pickup when mounted (#37861) by 8street
🛠️ Merge pull request #37862 from snipercup/Generic-name-to-object Generic Name to object by ZhilkinSerg
🛠️ Fix Nopalitos recipe (#37857) by jkraybill
🛠️ Merge pull request #37858 from jkraybill/37614b Display fragment mass with 2 decimal places by ZhilkinSerg
🛠️ [Python script shebang cleanup (Python script shebang cleanup #37859) * Use explicit Python version in json tools

These tools used '#!/usr/bin/env python' but required Python 2. This no
longer works on systems where Python 3 is the default.

Tweak their #! lines to specify python2.

Remove space from #! line
Make gfx_tools find python by path

The scripts in tools/gfx_tools were running /bin/python directly. The
convention is to use /usr/bin/env python, so switch to that.

Also, they were not executable. Make them so.

Make Python scripts executable

Some Python scripts had #! lines but were not executable. Make them so.](f2881ee) by jbytheway
🛠️ Name to object by snipercup
🛠️ fix #37614 by jkraybill
🛠️ Mapgen fixes for non-blacklisted mods by jbytheway
🛠️ Merge remote-tracking branches 'origin/pr/37713' and 'origin/pr/37661' by codemime
🛠️ Add looks_like support for fields (#37726) by ZhilkinSerg
🛠️ Merge pull request #37748 from LaVeyanFiend/Looks_Like_Mags Add looks_like for magazines by Rivet-the-Zombie
🛠️ [Migrate M47 from Magiclysm with Generic Guns active (#37659) * Fix Magiclysm guns showing with Generic Guns active

Revert gunblade migration in favor of Migrate ammotypes of guns, magazines, and mods #37746](da56791) by LaVeyanFiend
🛠️ Remove unused crowbar variable Caught by Travis CI by wapcaplet
🛠️ Fix item recipe info test cases Reduced to essential assertions; all passing now by wapcaplet
🛠️ Missing comma by LaVeyanFiend
🛠️ Remove duplicate looks_like by LaVeyanFiend
🛠️ Looks_like for explosive launchers and .50 ammo belt by LaVeyanFiend
🛠️ WIP Improve item recipe tests (still failing) Test coverage for modified item info behavior by wapcaplet
🛠️ Looks_like for 8x40 and .410 mags Looks_like for .410 mags by LaVeyanFiend
🛠️ Merge pull request #37826 from AMurkin/add-flag-edible-frozen Set a very low freezing_point for spice by ZhilkinSerg
🛠️ UltiCa updates to mainline (#37846) by I-am-Erk
🛠️ Merge pull request #37844 from olanti-p/fix-warnings Fix type cast warnings by ZhilkinSerg
🛠️ Merge pull request #37843 from olanti-p/fix-mut-lum-float Fix 'lumination' mutation value not using float by ZhilkinSerg
🛠️ Nail rifle magazine looks_like by LaVeyanFiend
🛠️ Looks_like for shotgun mags and speedloaders by LaVeyanFiend
🛠️ Looks_like for pressurized tanks by LaVeyanFiend
🛠️ Add magazine looks_like for SMGs by LaVeyanFiend
🛠️ Split off looks_like for revolver speedloaders by LaVeyanFiend
🛠️ Add looks_like to pistol magazines by LaVeyanFiend
🛠️ Looks_like for rifle magazines by LaVeyanFiend

CONTRIBUTORS

Last week there were 38 contributors.
👤 anothersimulacrum
👤 ifreund
👤 arijust
👤 ZhilkinSerg
👤 snipercup
👤 jbytheway
👤 KorGgenT
👤 BrettDong
👤 Rivet-the-Zombie
👤 TimPollard
👤 Cyrano7
👤 Fris0uman
👤 wapcaplet
👤 I-am-Erk
👤 Maleclypse
👤 jkraybill
👤 Ramza13
👤 wingbrother
👤 ektoplazm
👤 Kilvoctu
👤 davidpwbrown
👤 l29ah
👤 bug-sniper
👤 curstwist
👤 ashGlaw
👤 kevingranade
👤 AMurkin
👤 Night-Pryanik
👤 SeventhSandwich
👤 8street
👤 Brian-Otten
👤 Trioct
👤 tenmillimaster
👤 mlangsdorf
👤 RarkGrames
👤 LaVeyanFiend
👤 codemime
👤 Drack820

STARGAZERS

Last week there were 31 stagazers.
⭐ Willenbrink
⭐ Rainfey
⭐ zmeriksen
⭐ Gibbo3771
⭐ mokun
⭐ ektoplazm
⭐ dhullazaran
⭐ IDEXV
⭐ 641i130
⭐ xumoo
⭐ Mortalhys
⭐ DAmNslashA
⭐ Maximetinu
⭐ whoizit
⭐ dwarfmaster
⭐ evanhutomo
⭐ HarrisonHall
⭐ lgou2w
⭐ TheGeopard
⭐ pawpads
⭐ deciduously
⭐ MrTheMuffinMan
⭐ xdrie
⭐ RobotsFTW
⭐ Wexx
⭐ skshel123
⭐ CBeige
⭐ sachdevs
⭐ Limero
⭐ Wilou1428
⭐ sjoanez
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Feb 16, 2020

ZhilkinSerg closed this as completed Feb 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

weekly-digest bot commented Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

Comments

weekly-digest bot commented Feb 16, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES