Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for ghee #37913

Merged
merged 9 commits into from
Feb 11, 2020
Merged

Added recipe for ghee #37913

merged 9 commits into from
Feb 11, 2020

Conversation

ashGlaw
Copy link
Contributor

@ashGlaw ashGlaw commented Feb 11, 2020

Summary

SUMMARY: Features "Adds a recipe for ghee"

Purpose of change

Given how common ghee is in residential kitchens, you'd think you could make your own. But no, once it all goes bad, it's gone. That doesn't seem right

Describe the solution

I noticed we didn't have a ghee recipe, so I added one. It seemed similar to cooking_oil2 so I used that as a base. Watched some videos, and it looks very simple to make.

Describe alternatives you've considered

Should I add a rag to the components to represent straining through cheesecloth? Should it require a strainer?

Testing

I crafted ghee with both raw butter and butter. Worked both ways.

Additional context

I made a PR which adds ghee to frying_oil and lets you use it is many more recipes. This should go hand in hand with that improvement
#37604

I noticed we didn't have a ghee recipe, so I added one. It seemed similar to cooking_oil2 so I used that as a base. Should I add a rag to the components to represent straining through cheesecloth? Should it require a strainer?
@SeventhSandwich
Copy link
Contributor

Make it require a strainer. That would be a neat thing to find and be useful for something.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Feb 11, 2020
data/json/recipes/food/dairy_products.json Outdated Show resolved Hide resolved
data/json/recipes/food/dairy_products.json Outdated Show resolved Hide resolved
ashGlaw and others added 4 commits February 11, 2020 01:37
The book should spawn in a number of different places now, with a fairly low distribution. Not married to those numbers, though
@I-am-Erk
Copy link
Member

The only downside to including the cookbook in this PR is that I'll have to Content Freeze it. If you want to add ghee right now, we could have the recipe in "cooking on a budget" (item id is just "cookbook") as well, and your pr to add the recipe could just put it in there. Then we can add the Indian cookbook in a separate PR, which would be subject to content freeze, but this PR could go through since it's just adding a recipe for existing content.

@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 11, 2020

Cool! Sure thing. I'll get that settled.

Thanks, Erk

@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 11, 2020

Things should be right and proper now. Tested to see if the recipe appeared in cooking on a budget, and it does.

@ashGlaw ashGlaw requested a review from I-am-Erk February 11, 2020 20:54
@I-am-Erk
Copy link
Member

Yay Travis passed the calorie test.

@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 11, 2020

Is there anything left outstanding?

@I-am-Erk I-am-Erk merged commit 011455f into CleverRaven:master Feb 11, 2020
@I-am-Erk
Copy link
Member

Nope it's done, just hasn't registered as passed yet

@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 12, 2020

Thanks for all your help. thrilled to have this as part of 0.E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants