Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracts and Concentrates pt 5 #37956

Merged

Conversation

NastyNate2612
Copy link
Contributor

adds shatter, wax, distillate, distillate cartridges, and a whole bunch of steps in between that i dont suggest u ingest or consume

Summary

SUMMARY: Content "pt 5 of my extracts and concentrates mod adding into mainline"

Describe the solution

-shatter : form of cannabis concentrate/extract
-wax: form of cannabis extract
-distillate: form of cannabis extract
-distillate carts: used with the dab pen, also a form of cannabis extract
-and a whole bunch of comestibles that are the steps in between, i dont suggest anyone try to consume those
Most of these items wont make sense until you're going through the steps and craft the end resulting items yourself.

Testing

crafted and test smoked/ingested all comestibles

adds shatter, wax, distillate, distillate cartridges, and a whole bunch of steps in between that i dont suggest u ingest or consume
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 12, 2020

Soon we’re gonna hafta start adding different strains of cannabis. At least maybe an indica/sativa distinction

@curstwist curstwist added [JSON] Changes (can be) made in JSON Artifacts Otherworldly items with special effects Items / Item Actions / Item Qualities Items and how they work and interact and removed Artifacts Otherworldly items with special effects labels Feb 12, 2020
@NastyNate2612
Copy link
Contributor Author

Yes that's why I made the Id names the way they are, to leave room open for different concentrates from different strains

@GhostEcho
Copy link

I mean honestly, after smoking for years, while there is some distinction in effects at first, they really start blending together and just all start feeling like hybrids.

@NastyNate2612
Copy link
Contributor Author

I mean honestly, after smoking for years, while there is some distinction in effects at first, they really start blending together and just all start feeling like hybrids.

Aint that the truth... smh... the different effects with strains i guess would be to give you some incentive to grow gorilla glue#4 or Sour Diesel compared to a higher yielding strain like blue dream. OHHHH SNAP I GOT IT! Ok so what makes these strains differ irl?

  1. Value (some strains are more expensive than others due to supply and demand),
  2. Yield when harvested (some strains yield exponentially more than others)
  3. Amount of Cannabinoids/THC (some strains are stronger than others, and when processed yield higher quantities of crude oil)
    sooooo there we go, now i have a template for making new strains when i start overhauling the farming system in the game

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 16, 2020 12:03
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from 924f105 to 39e00e3 Compare March 18, 2020 07:00
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from ad63e77 to 8e68539 Compare April 1, 2020 12:18
@kevingranade kevingranade force-pushed the dev branch 4 times, most recently from 621a68e to b7106d0 Compare April 2, 2020 07:42
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from 0f30a43 to d432807 Compare April 2, 2020 12:55
@ZhilkinSerg ZhilkinSerg changed the base branch from dev to master April 2, 2020 21:47
Copy link
Contributor Author

@NastyNate2612 NastyNate2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular comestible (distillate cart) uses the Dab Pen (On) as the tool which runs on battery power so a fire source shouldn't be required.

data/json/items/comestibles/med.json Outdated Show resolved Hide resolved
@kevingranade
Copy link
Member

Ahh I see my mistake, I had assumed it was a typo since "need_charges": 1 isn't valid.
Just need to double check that it consumes charges and such as expected and we're good to go.

@NastyNate2612
Copy link
Contributor Author

Ahh I see my mistake, I had assumed it was a typo since "need_charges": 1 isn't valid.
Just need to double check that it consumes charges and such as expected and we're good to go.

Yeah this was the only way I could get the item to use charges properly with only doing JSON stuff. It would need a item use action similar to the e-cig if we wanted it to be perfect

@NastyNate2612
Copy link
Contributor Author

i kinda had a similar issue with the extractors too, hence the (On) versions of them all to use power properly. Ill do some experimentation to see if i can get a tool to use charges properly when only referenced by qualities

@NastyNate2612
Copy link
Contributor Author

Thank You Kevin for your help on this and everything you do for the game! also thank you for string cleanup, and thank you for adding my contributions :-)

@kevingranade kevingranade merged commit 140d058 into CleverRaven:master Apr 27, 2020
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
adds shatter, wax, distillate, distillate cartridges, and a whole bunch of steps in between that i dont suggest u ingest or consume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants