Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basements 1 #37863

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Add basements 1 #37863

merged 2 commits into from
Feb 10, 2020

Conversation

curstwist
Copy link
Contributor

@curstwist curstwist commented Feb 9, 2020

Summary

SUMMARY: Content "Adds basic basements to 9 houses."

Purpose of change

We need explicit stair placement between z levels. This begins adding basements shaped to each house foundation.

Describe the solution

I'll be adding these quickly so each house can have it's own stairs and it will alleviate the teleporting stairs in houses.

These basements are unfinished (as in basement style, not incomplete mapgen). They get some basic appliances like the hot water heater and furnace. Most also get a washer & dryer and a few random boxes.

Once all these houses have matching basements, I'll be adding variants or nested maps to add more variety.

Describe alternatives you've considered

I considered waiting to do this until 0.E, but the stairs in houses are messy right now since I added the roofs and broke up the ubiquitous "house" ID.

I considered waiting until I had nested maps or more interesting variants, but I think the stair mechanics win over variety. I do have houses to add to the current basements, so they won't be removed. Some will get an overhaul though.

I plan on making some of the special basements, like the gun theme, into nested chunks so they can spawn in a variety of houses.

Testing

Spawned in world.

Additional context

I did say basic:

This is for house_detatched 1 through 9.
detatched1
detatched2
detatched3
detatched4
detatched5
detatched6
detatched7
detatched8
detatched9

@curstwist curstwist added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 9, 2020
@I-am-Erk I-am-Erk merged commit 1e58b1d into CleverRaven:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants