Remove bubble car spawns #38050
Merged
Remove bubble car spawns #38050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minireactor powered vehicles haven't fit in canon fore a while, so they shouldn't be spawning. Have them spawn in Aftershock instead.
I-am-Erk
added
[JSON]
This was referenced Feb 16, 2020
anothersimulacrum
added a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jun 19, 2020
Atomic cars haven't been canon in vanilla for a while (CleverRaven#38050), and this appears to have been errorneously added in CleverRaven#40706
anothersimulacrum
added a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jun 19, 2020
Atomic cars haven't been canon in vanilla for a while (CleverRaven#38050), and this appears to have been erroneously added in CleverRaven#40706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Minireactor powered vehicles haven't fit in canon fore a while, so they shouldn't be spawning.
Describe the solution
Remove bubble car spawns from core, and stick them in Aftershock
Describe alternatives you've considered
Just removing them.
Testing
tests/cata_test --mods="aftershock" '~*'runs without errors (loading the data for the mod).Running the tests have no failures. (Attempting to run the tests with aftershock leads to unrelated vehicle weight failures).