houses for legacy basements #37939
Merged
houses for legacy basements #37939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds houses for the legacy basements."Purpose of change
Continue basement project.
Includes 2 houses designed to support basements relying on the c++ stair generation and original "basement" ID, it also includes the lab basements.
I've decided this is the best approach for the lab basements in particular until after 0.E is released to ensure they aren't broken. I've made two large houses that have plenty of room for stairs to spawn and I've added the game basements (D&D, Rec rooms) the gun basement (until I phase it out with nested chunks), and the hidden lab basements.
Note: lab basements will be rarer then they were before, I'm seeing a ~5 per overmap chunk in mega city world.
Testing
Spawned in world.
Additional context
For now, these houses don't have dedicated stairs and will use the c++ stairs for basement access.
house31:
house32:
