Migrate M47 from Magiclysm with Generic Guns active

[ghost]

Summary

SUMMARY: Bugfixes "Fix Magiclysm guns showing when using Generic Guns"

Purpose of change

Guns from Magiclysm can show up when also using Generic Guns, and keep their original ammo types rather than being generalized.

Describe the solution

Add gunblade and M47A1 to GG migration list.

Describe alternatives you've considered

None.

Testing

Tested with just GG active: No visible load errors(blacklisting the guns instead does cause a load error).
Tested with both active: Guns show as original when first started, reloading the world causes migration regardless of mod loading order.

Additional context

@esotericist said to put this fix out now so it isn't forgotten for after the migration code is fixed to migrate on first use of a world.

[I-am-Erk]

I'm not sure about this M47A1 dealy, but isn't the gunblade a fairly specific weapon to magiclysm? generic guns isn't about not getting any guns to play with, it's about making the choices simple. You might just want to change the accepted ammo type in GG.

[esotericist]

I'm not sure about this M47A1 dealy, but isn't the gunblade a fairly specific weapon to magiclysm? generic guns isn't about not getting any guns to play with, it's about making the choices simple. You might just want to change the accepted ammo type in GG.

For the M47A1: It's literally just a revolver that kiiiiiinda sucks in real life made to suck slightly less through the use of magic, and the ultimate effect gets you a gun that works exactly the same as the basic revolver in Generic Guns (due to the loss of differentiation of ammo types). So it migrating to the GG revolver is the right call.

As for the gunblade having its stats changed? This isn't actually simple in our current mod framework; if generic guns refers to content from magiclysm in any form other than migration, it results in errors if the player has generic guns and not magiclysm.

Fixing in that fashion will require code support that I honestly have no idea how to do, or it will require a compatibility mod for integration. I don't think either is appropriate in the lead-up to 0.E, but I would like to see something better after.

[KorGgenT]

the m47A1 is basically "i can use a bunch of different ammo" so that makes sense to migrate, but you do have a good point. I don't know how it would work to migrate the ammo of an item from a different mod such that they don't have a real dependency on each other though

[I-am-Erk]

I'd suggest just migrating gunblade to gunblade_generic perhaps?

[esotericist]

I'd suggest just migrating gunblade to gunblade_generic perhaps?

How would that work?

Are you wanting to put a gunblade_generic in magiclysm that uses the generic gun ammo type? That would error if generic guns is absent.

Are you wanting to put a gunblade_generic definition in Generic Guns? I'm not prepared to believe Generic Guns has a responsibility to have generic versions of weapons from content mods.

[esotericist]

So on review, this definitely needs a code solution for the gunblade; it should be possible to have its ammo usage automatically migrated without us needing to specify anything in the generic guns mod at all. I'm looking into that now.

the techno medusa migrating to a revolver is still the way to go, imo.