Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS file to alert mod maintainers to changes in their mods. #37662

Merged
merged 6 commits into from
Feb 11, 2020

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Feb 3, 2020

Summary

SUMMARY: Infrastructure "Use github's code owner system to alert mod maintainers to changes."

Purpose of change

With several mod maintainers now trying to keep track of changes to their mods, we need an easy system to alert them to review when the mods the maintain have PRs waiting.

Describe the solution

Luckily, github has exactly such a function.
Unfortunately it is named "code owners" which has a different meaning than we would like to imply, but such is life. I added a disclaimer to the top of the file.

Describe alternatives you've considered

The Labels system does some of this work but requires an active role.

Additional context

I added alerts requested by KorgGenT and my own, unrelated to mods.

@I-am-Erk I-am-Erk added the <Documentation> Design documents, internal info, guides and help. label Feb 3, 2020
@Rivet-the-Zombie
Copy link
Member

A cool feature with an unfortunate name. Seize the means of compiling, and all that.

@ZhilkinSerg ZhilkinSerg added the Organization General development organization issues label Feb 3, 2020
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
I-am-Erk and others added 2 commits February 3, 2020 14:50
Co-Authored-By: Curtis Merrill <[email protected]>
Co-Authored-By: Curtis Merrill <[email protected]>
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@damien damien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. Organization General development organization issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants