-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CODEOWNERS file to alert mod maintainers to changes in their mods. #37662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
the
<Documentation>
Design documents, internal info, guides and help.
label
Feb 3, 2020
A cool feature with an unfortunate name. Seize the means of compiling, and all that. |
KorGgenT
reviewed
Feb 3, 2020
KorGgenT
reviewed
Feb 3, 2020
Co-Authored-By: Curtis Merrill <[email protected]>
Co-Authored-By: Curtis Merrill <[email protected]>
damien
reviewed
Feb 4, 2020
Co-Authored-By: Damien Wilson <[email protected]>
damien
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced Feb 9, 2020
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
<Documentation>
Design documents, internal info, guides and help.
Organization
General development organization issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Use github's code owner system to alert mod maintainers to changes."
Purpose of change
With several mod maintainers now trying to keep track of changes to their mods, we need an easy system to alert them to review when the mods the maintain have PRs waiting.
Describe the solution
Luckily, github has exactly such a function.
Unfortunately it is named "code owners" which has a different meaning than we would like to imply, but such is life. I added a disclaimer to the top of the file.
Describe alternatives you've considered
The Labels system does some of this work but requires an active role.
Additional context
I added alerts requested by KorgGenT and my own, unrelated to mods.