Clean some exothermic CBM code #38020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Clean some exothermic CBM code"Purpose of change
Clean some exothermic CBM code
Might be related to #37586 but I just can't reproduce the bugs in my testing both ethanol burner and gasoline fuel cell barely produce any heat.
Describe the solution
Remove pointer that are not usefull for simple types like int
Add a check to the emit_id, to avoid ethanol burner emits "emit_hot_air0_cbm" which does not exist
Describe alternatives you've considered
Testing
Compile without error
Additional context