Gun barrel length to string #37887
Merged
Gun barrel length to string #37887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: nonePurpose of change
Contributes to #36110
Describe the solution
Changes barrel_length from an integer (which I think represents inches) to a string. The amount of ml I put in is the integer multiplied by 250. The barrel_length properties are now strings for all vanilla guns.
Describe alternatives you've considered
Not changing
Testing
The guns before sawing:
The amount of moves required before the change:
The result of sawing before the change:
The amount of moves required after the change (it's a couple of moves more then before)
The result of sawing after the change (same result in volume as before)
