Add looks_like support for fields #37726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
SDL: Tiles / Sound
|
calling this high priority since all the tests are failing without it |
This was referenced Feb 9, 2020
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Feb 9, 2020
Add looks_like support for fields (CleverRaven#37726)
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add looks_like support for fields"Purpose of change
Allow easy tile fallback for fields.
Describe the solution
Add looks_like support for fields in a similar fashion to terrain and furniture.
Testing
Make a new field with
looks_likeproperty, spawn it through debug menu and see that it has same tile as its lookalike.Make a new field using
copy-from, spawn it through debug menu and see that it has same tile as its parent field type.Additional context
Prerequisite for #37706 which can be merged after or together current PR.
We should probably allow different tiles for different field levels, but that's out-of-scope in current PR.