add more basements #37931
Merged
add more basements #37931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
[JSON]
|
I'm so happy that the average basement is tilesetted out nicely. |
I-am-Erk
reviewed
Feb 11, 2020
| ], | ||
| "place_monster": [ { "monster": "mon_broken_cyborg", "x": 14, "y": 3, "chance": 100 } ] | ||
| } | ||
| }, | ||
| { | ||
| "type": "mapgen", | ||
| "method": "json", | ||
| "om_terrain": [ "basement" ], | ||
| "om_terrain": [ "basement_bionic_decoy" ], |
There was a problem hiding this comment.
If you give this the same ID, basement_bionic, and just comment on it being a decoy, you won't need separate overmap entries and things. The game will just select which map to use based on weight.
There was a problem hiding this comment.
I did this because bionic_basement is a scenario start location and I don't want people spawning in the wrong basement model. I don't do it to other matching basements.
There was a problem hiding this comment.
Ah, yeah I didn't notice it for the others either. that makes sense.
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds basements to more houses."Purpose of change
Continue basement project.
Includes house_08 through house_12 and associated basements.
House_09 gets two variants for the bionic basement & its decoy.
House_08 basement is shared with house_dogs
House_10 basement is shared with house_suicide.
I also fixed bad stair placement for house_05ab basement.
Testing
Spawned in world.
Additional context
mostly basic basements. I did expand the bionic basements to fit their house floor plan.
House_08 & house_dogs:
bionic basements (house_09/house_09b)
house_10 & house_suicide:
house_11
house_12
