Chemical Revolution: Chemistry Skill and Lithium #38005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the "Practice makes Perfect' project has barely been touched, I decided that I'd go ahead with separating the Cooking skill into two different skills.
Change some recipes to take into account the new recipe book I added, and added a few lithium items as well as hydrofluoric acid. Still not in itemgroups, nor do they have recipes. That will be done in the next commit.
|
Lol i just put out my extracts and concentrates data the other day. whenever this gets added ill have to go and change the skill requirements for all the recipes for it |
ZhilkinSerg
added
0.E Feature Freeze
<Enhancement / Feature>
For later commits and later PRs, I decided to add a lower-level organic chemistry textbook to go with the lower-level inorganic chemistry textbook I already added. Might break this up if suggested.
Added a "high school"-level chemistry textbook for levels 0 through 2.
|
For personal reference after I return on Sunday: |
If your PRs get merged first, I'll make sure to make a new PR to take your changes into account. |
This was referenced Feb 16, 2020
|
Feel free to reopen if you want working on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Separate Chemistry from Cooking and add Lithium reaction recipes"Purpose of change
To start the expansion of chemistry in Cataclysm.
Describe the solution
As the base of any and all Chemical Revolution PRs I make, I separated the cooking skill into cooking and chemistry and plan to add lithium and lithium reactions as the first step.
Describe alternatives you've considered
For the skill separation? Proficiencies as mentioned in the Practice makes Perfect project. For the lithium stuff? I dunno.
Testing
Find lithium in labs, on scientists, etc. Make chemistry recipes to advance chemistry skill.
Additional context
First part of my "Chemical Revolution" series of PRs.