Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copper scrap:copper ratios for crafting recipes (#37817) #37884

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

jkraybill
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fix copper scrap:copper ratios for crafting recipes"

Purpose of change

Fixes #37817.

Describe the solution

I audited all the recipes that use copper scrap, or copper in quantities above 25. I found that the bug report was correct -- while the copper tubing recipe was correctly using 7 scrap or 175 copper, 9 other recipes either used a ratio of 1 scrap:100 copper (overpowered for scrap), or did not accept scrap when it seemed like they should.

I added a new material, "copper_scrap_equivalent", which is either 1 copper scrap or 25 copper, and fixed the recipes in the following ways:

Copper Bracelet: was 60 copper, now is 2 scrap equivalent (now accepts scrap, slight reduction in mass used, still uses more than the output mass)
Wooden Canteen: was 20 copper, now 1 scrap equivalent (now accepts scrap, slight increase in mass used)
Makeshift Copper Pot: was 4/400, now 16 SE (fixed scrap ratio)
Copper Axe: was 10/1000, now 40 SE (fixed scrap ratio)
Copper Pot: was 5/500, now 20 SE (fixed scrap ratio)
Copper Tubing: was 7/175, now 7 SE (no functional change)
Neoprene Sheet: was 50 copper, now 2 scrap equivalent (now accepts scrap)
Bronze: was 50 copper, now 2 scrap equivalent (now accepts scrap)
Copper Knife: was 2/200, now 8 SE (fixed scrap ratio)
Copper Spear: was 3/300, now 12 SE (fixed scrap ratio)

Describe alternatives you've considered

I considered revising copper requirements down, but after doing the math on the input:output weight ratios, it seemed apparent that the scrap quantities were too low, not the copper too high. See attached spreadsheet for calculations: 37817.xlsx

I also considered not adding scrap to the recipes that didn't already need it, but given that you could already make things like a copper pot out of scrap, I saw no reason you shouldn't be able to in other recipes. Bronze was the only one that maybe there's an argument for?

Testing

Spawned a bunch of bronze and bronze scrap before and after the update, repro'd the issue, checked out the copper recipes, and verified the above numbers afterwards.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 10, 2020
@ZhilkinSerg ZhilkinSerg merged commit 1dc79b2 into CleverRaven:master Feb 10, 2020
@jkraybill jkraybill deleted the 37817 branch February 10, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrap copper requires less units off copper than is used in crafting
2 participants