Fix copper scrap:copper ratios for crafting recipes (#37817) #37884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix copper scrap:copper ratios for crafting recipes"
Purpose of change
Fixes #37817.
Describe the solution
I audited all the recipes that use copper scrap, or copper in quantities above 25. I found that the bug report was correct -- while the copper tubing recipe was correctly using 7 scrap or 175 copper, 9 other recipes either used a ratio of 1 scrap:100 copper (overpowered for scrap), or did not accept scrap when it seemed like they should.
I added a new material, "copper_scrap_equivalent", which is either 1 copper scrap or 25 copper, and fixed the recipes in the following ways:
Copper Bracelet: was 60 copper, now is 2 scrap equivalent (now accepts scrap, slight reduction in mass used, still uses more than the output mass)
Wooden Canteen: was 20 copper, now 1 scrap equivalent (now accepts scrap, slight increase in mass used)
Makeshift Copper Pot: was 4/400, now 16 SE (fixed scrap ratio)
Copper Axe: was 10/1000, now 40 SE (fixed scrap ratio)
Copper Pot: was 5/500, now 20 SE (fixed scrap ratio)
Copper Tubing: was 7/175, now 7 SE (no functional change)
Neoprene Sheet: was 50 copper, now 2 scrap equivalent (now accepts scrap)
Bronze: was 50 copper, now 2 scrap equivalent (now accepts scrap)
Copper Knife: was 2/200, now 8 SE (fixed scrap ratio)
Copper Spear: was 3/300, now 12 SE (fixed scrap ratio)
Describe alternatives you've considered
I considered revising copper requirements down, but after doing the math on the input:output weight ratios, it seemed apparent that the scrap quantities were too low, not the copper too high. See attached spreadsheet for calculations: 37817.xlsx
I also considered not adding scrap to the recipes that didn't already need it, but given that you could already make things like a copper pot out of scrap, I saw no reason you shouldn't be able to in other recipes. Bronze was the only one that maybe there's an argument for?
Testing
Spawned a bunch of bronze and bronze scrap before and after the update, repro'd the issue, checked out the copper recipes, and verified the above numbers afterwards.