Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pickup items while mounted using examine #37861

Merged
merged 9 commits into from
Feb 9, 2020
Merged

Fix pickup items while mounted using examine #37861

merged 9 commits into from
Feb 9, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Feb 9, 2020

Summary

SUMMARY: Bugfixes "Fix pickup items while mounted using examine"

Purpose of change

Fixes #37836

Describe the solution

I'd added an additional condition.

Describe alternatives you've considered

Refactor examine function because if( u.is_mounted() ) repeated therein many times. But I have no idea about the functions used in game::examine().

Testing

Load game
Get saddled horse
Riding and examine many items

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Feb 9, 2020
@ZhilkinSerg ZhilkinSerg merged commit 5e69069 into CleverRaven:master Feb 9, 2020
@8street 8street deleted the Fix_pickup_items_while_mounted_using_examine branch February 9, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can pick up items while mounted using (e)xamine, but not (g)et or AIM
2 participants