Fix missing mapgen keys for non-blacklisted mods #37845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
This was referenced Feb 9, 2020
jbytheway
force-pushed
the
mapgen_fixes_mods
branch
from
6fd9a0c to
4851466
Compare
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
As #37839, fixing mapgen where keys have no defined function (so that such can be made an error).
Describe the solution
Fix errors in non-blacklisted mods.
Describe alternatives you've considered
As in #37839, these changes are somewhat subjective.
Testing
None worth speaking of.
Additional context
@curstwist is responsible for the Black dragon lair, I believe.
The Salvaged Robots mod doesn't seem to have a maintainer.
Once this and #37839 are merged, I plan to make undefined mapgen keys a (test-mode-only) error. Making it an error in regular play would require also fixing errors in the blacklisted mods. There are an awful lot of errors in More Locations in particular, so I probably won't fix them all.