Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indian cookbook #37930

Merged
merged 17 commits into from
Mar 10, 2020
Merged

Indian cookbook #37930

merged 17 commits into from
Mar 10, 2020

Conversation

ashGlaw
Copy link
Contributor

@ashGlaw ashGlaw commented Feb 11, 2020

Summary

SUMMARY: Content "Adds new Indian Cookbook with recipes in"

Purpose of change

This started with adding a recipe for ghee here: #37913
Instead of setting its recipe to the default cookbook I wanted to add an Indian cookbook, ripe for further expansion.

Describe the solution

I found a book I liked the look of online and made the cookbook using it as a base. I made it somewhat rare in the itemgroups, but spawn in many. I made the curry recipes book_learn and put their recipes in here.

Describe alternatives you've considered

I think the idea is sound, I just feel bad for having so little content to put into it. Plenty of room for expansion

Testing

I spawned and read the book in game. I crafted ghee. Both worked fine

Additional context

This was moved to a separate PR because of the content freeze. It will have to wait.

ashGlaw and others added 8 commits February 10, 2020 23:05
I noticed we didn't have a ghee recipe, so I added one. It seemed similar to cooking_oil2 so I used that as a base. Should I add a rag to the components to represent straining through cheesecloth? Should it require a strainer?
The book should spawn in a number of different places now, with a fairly low distribution. Not married to those numbers, though
@I-am-Erk I-am-Erk added 0.E Content Freeze [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Feb 11, 2020
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other recipes you could add:
curry_powder
yoghurt
cheese_hard
chai_tea
sauce_red
deluxe_veggy_rice
deluxe_veggy_beansnrice

Eventually I think all of these except maybe red sauce are recipes we want to take autolearn away from too, but there's a bigger PR for that so you can leave it for now if youw ant.

We could probably have a few more indian foods added at some point. I'd love to have naan bread and paneer and various different curries.

data/json/recipes/recipe_food.json Outdated Show resolved Hide resolved
@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 11, 2020

Cool. Good suggestion to have the recipe in both books, Erk.

Anything else needs doing?

@Shibimon
Copy link

Shibimon commented Feb 12, 2020

While adding an indian cookbook its a really good idea for variety and could lead to regional rare cookbooks, i think "ghee" that is just clarified butter is used enough in other cuisines to still be on more common books.
Butter is clarified melting it and removing the bit of liquid protein and other leftovers to keep only the pure fat and its useful in other not-indian regional foods like strudel or baklava in real life and widely used in other common foods, cause butter with liquid proteins tend to inflate and deform delicate preparations.

@ashGlaw
Copy link
Contributor Author

ashGlaw commented Feb 12, 2020

Ghee and clarified butter are nearly the same thing, I agree. I considered replacing ghee with clarified butter. But this way encourages the addition of more recipes.

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 10, 2020 08:56
@ZhilkinSerg ZhilkinSerg merged commit f084779 into CleverRaven:dev Mar 10, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 10, 2020
13 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 10, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 29, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants