Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak mapgen for animal pound #38046

Merged
merged 8 commits into from
Feb 21, 2020
Merged

Tweak mapgen for animal pound #38046

merged 8 commits into from
Feb 21, 2020

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Feb 15, 2020

Summary

SUMMARY: Bugfixes "Tweak mapgen for animal pound"

Purpose of change

Close #38000

Describe the solution

Tweak existing map.

Describe alternatives you've considered

Make entirely new one and close this PR.

Additional context

It should be all.

@arijust arijust changed the title [WIP] Tweak mapgen for animal pound Tweak mapgen for animal pound Feb 17, 2020
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 17, 2020
@curstwist
Copy link
Contributor

can you add some screenshots of your changes?

@I-am-Erk
Copy link
Member

Can post a picture or two of your work?

@arijust
Copy link
Contributor Author

arijust commented Feb 18, 2020

Unfortunately, I am unable to post any images here as my router is broken piece of garbage.
Sorry.

@cosmiccoincidence
Copy link
Contributor

Seems they simply removed the part of the building obstructing the vehicle to the road. I'm referring to the outdoor dog cages.

I think an alternative to this is simply swapping the locations of the vehicle and outdoor cages as opposed to outright removing them as they are kinda neat. But this aesthetic could also be preserved by making another animal shelter map so we have 2 variants.

@I-am-Erk
Copy link
Member

Yes, that's what it was looking like to me, and I'd argue the animal cages are a far more important part of the pound than the vehicle spawn.

@curstwist
Copy link
Contributor

curstwist commented Feb 18, 2020

hey, i went ahead and loaded this for screenshots.
animal pound 1

The vehicle spawn location issue (assuming its still in the back) isn't alleviated:
problem

You'll need to spawn it in the front of the building and push the building back to the edge of its map, or redo a side and put it there.

@I-am-Erk
Copy link
Member

If doing that, you should also move the building closer to the edge of the map and put those animal cages off to one side, because as I said, I feel pretty strongly that they're more important than the vehicle. There's room for them... but like I said in the issue, it means redrawing most of the map.

Made second vet office.

Modification of spawns will come out at later date.
@Rivet-the-Zombie Rivet-the-Zombie merged commit 7cc215e into CleverRaven:master Feb 21, 2020
@I-am-Erk
Copy link
Member

Did the problem of the deleted cages get resolved? I wasn't quite ready to merge this yet

@cosmiccoincidence
Copy link
Contributor

Made second vet office.

I don't see a second vet office added...

@arijust
Copy link
Contributor Author

arijust commented Feb 21, 2020

Darn it. It wasn't ready to merge yet.

@arijust arijust deleted the animal_pound branch February 21, 2020 22:47
@cosmiccoincidence
Copy link
Contributor

You can put "[WIP]" at the beginning of the PR's title to let mergers know not to merge until you remove "[WIP]" from the title.

@arijust
Copy link
Contributor Author

arijust commented Feb 21, 2020

I guess, I will need to add missing parts in other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animal Pound building has bad placement feature.
7 participants