Fix clang-tidy error with panels.cpp #37988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix clang-tidy error with panels.cpp"Purpose of change
One of my merged PR #37973 has caused an error with Clang-tidy CMake build with Tiles and Sound (in panels.cpp at line 1471):
error: Prefer constructing 'point' from named constant 'point_east' rather than explicit integer arguments. [cata-use-named-point-constants,-warnings-as-errors]Describe the solution
In panels.cpp, each similar line that does point construction for drawing panels is preceded by:
// NOLINTNEXTLINE(cata-use-named-point-constants)I'm inserting this line into the trouble spot.
Describe alternatives you've considered
Going through panels.cpp and simplifying point construction for the 26 instances in which no lint has been declared for it, but I'm concerned that this may cause further issues.
Testing
None. Allowing the continuous integration thing to test it.
Additional context
This error was discovered when looking at the tests for #37981. Link