Fix ui hotkey help not updating #37981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix ui hotkey help not updating"Purpose of change
There are a number of UI windows in the game in which the hotkeys reminder text are statically written out.
For example, "[?] show help" on Advanced Inventory Management. If the user changes the hotkey for help away from
?, this reminder text does not change.This PR addresses a couple windows with this issue, using the standard "[
keybind]action" format.Describe the solution
Rewrite reminder text to reference their respective appropriate actions' current keybinds.
Change
press_xtoget_descwhere it makes sense.Describe alternatives you've considered
Some windows have a very large amount of static reminder text. These are the UI for crafting, aiming, zones manager and vehicle examine.
Especially in the case of the vehicle UI, these are difficult to fix without making a relatively large impact on how the text is displayed, so I've left them out of this PR.
Incidentally, in the case of crafting, aiming and zones manager UI, I feel it's better to have "[
keybind] show help" rather than so much reminder text on screen. There should be only essential reminders listed in each window, as the menu for showing keybindings is already accessible everywhere (and is contextual).Testing
Compile, load game, open the affected windows and remap keybinds. Observe results.