Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONize mending modifier from mutations #37987

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

The effect mutations have on limb mending was hardcoded in a if/else ladder. Yuck! Also, some of the slow healer mutations were not having an impact on mending speed, so add that.

Describe the solution

Add mending_modifer value to mutations, of type float.
Add code to load this, and replace the if/else ladder with multiplying times this multiplier.
Add this value to mutations.

Testing

Break an arm, and debug in the reptilian healing mutation. Sleep, and notice that your arm mends very quickly, as it should.

doc/JSON_INFO.md Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Feb 13, 2020
The effect mutations have on limb mending was hardcoded in a if/else
ladder. Yuck! Also, some of the slow healer mutations were not having
an impact on mending speed, so add that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants