Fix trait-less characters not mending broken limbs. #42594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default mutation mending_modifier is set to 1.0, but when no mutations are present, `mutation_value( "mending_modifier" )` returns zero, which is the starting/default value in `calc_mutation_value`.
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now trait-less characters cannot heal broken limbs at all. Even with splint on the limb never gets mending effect ("Started recovery").
This PR fixes that.
SUMMARY: [Bugfixes] "[Fix mending of limbs for trait-less characters]"
Purpose of change
Fixing the bug.
Steps to reproduce:
Describe the solution
Currently default mutation mending_modifier is set to 1.0, but when no mutations are present,
mutation_value( "mending_modifier" )returns zero, which is the starting/default value incalc_mutation_value.Solution is to treat
mending_modifieras multiplicative, as it was intendedDescribe alternatives you've considered
None.
Testing
Built the game, put on the splint, got "Started recovery (right leg)" effect.
Additional context
The bug was introduced in #37987 ; cc @anothersimulacrum