CRIT Expansion Update #33556
Merged
CRIT Expansion Update #33556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
|
Having difficulty seeing if enemies spawn or not, unsure if its because its RNG or because it's being overlooked. |
|
Stumbled on this looks cool famalam! |
ghost
mentioned this pull request
|
should be
|
|
Another check in the box! |
|
Nice! I did it guys! I have stamped out all the bugs and now I can definitely run a 100% good playtest. Edit: Nvm, something else went wrong. |
Hate when that happens but it at least it's progress. :) |
Wishbringer
reviewed
Apr 8, 2020
Arcangelus
reviewed
Apr 20, 2020
Copy-pasting mutations can have some weird side effects, depending on the order the definitions ends up loaded. This way will avoid that, save space and allow the trait to be in line with any future vanilla change short of deletion. For a few, it also fixes unintended nerfs: FASTHEALER didn't include "mending_modifier" : 2 WEAKSCENT didn't include scent_intensity, so it was useless. PRETTY lacked visibility. THINSKIN lacked a recent nerf of -1 bash. ALBINO, SUNBURN lacked a type. I also removed the mutations GOODHEARING, FANGS, NAILS from here as nothing was done with those.
Changed to use the preferred extend format where applicable. Nothing else changed. The following unintended nerfs were reverted: SMELLY lacked scent_intensity, probably negating its effect. REGEN lacked mending_modifier:16
Update crt_vamp_mutations.json
Co-Authored-By: Arcangelus <[email protected]>
Co-Authored-By: Arcangelus <[email protected]>
|
I am finally ready, whoo hoo |
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Update"Purpose of change
The start of a line of changes that aims to slowly flesh out the identity of the CRIT content mod. My mission is to refine a mod that evolves into a more polished experience that reflects well on the devs and maintainers that are a part of this wonderful community.
Basic rebalance or additions:
MA Styles have been balanced to fit their respective themes.
The Rivet Gun no longer produces explosions or shrapnel.
Guns have been majorly buffed
Techniques offer less eye-stress in regards to the descriptions and should feel more "correct"
Minor Mutation additions
Various items have been changed
Major Changes:
Dark Souls content will become a new mod PR (moved for now)
Dead Space content will stay to avoid destroying saves
Extended Techniques will stay in the mod (to avoid destroying old saves)
Checklist
Resolve all the issues and get back into standards:
Weight Strings
Sufficient Spaces
Miscellaneous
Re-do files that have been modified to pass conflicts back to rebalanced version:
Items
Constructions
Martial arts
Classes/ Scenarios