-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Professions start with magazines/holsters loaded with their items + missing batteries #33912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
labels
Sep 9, 2019
Fris0uman wants it consistent across both genders due to Foodperson NPC
kevingranade
reviewed
Sep 9, 2019
kevingranade
reviewed
Sep 9, 2019
ghost
requested a review
from kevingranade
September 10, 2019 03:54
Interesting! That would help greatly, as I feel my classes are rather clunky when you have to continue pulling out 4 gun mods out of the holster and then to add further insult, install them all one by one. Honestly I'll have to look through your code to understand what you did to solve this, and I'm still on a mini-hiatus so it will be a few days once I finish sorting irl stuff again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Professions have batteries for their devices, and use their holsters/pouches"
Purpose of change
Fixes #33824, completes #33366, and streamlines having to holster/load all the profession spawn items that should've been holstered/loaded already.
Describe the solution
1.Created new charged_mp3, charged_tazer, and charged_two_way_radio item groups, and changed the charged_flashlight & cellphone item groups to reflect the change to individual batteries. This will make it easier to buff/nerf later, as you'd otherwise have to find each item and change their first acceptable magazine to change the battery each starts with.
2. Went through all professions except C.R.I.T.(Have asked Soupster if he'll do it in #33556, will do second PR if not) and used entries to make use of all holsters/magazines a profession has if they also have an item that fits inside said holster/mag.
3. Corrected Archaelogist missing the 7 rounds from their revolver.
4. Added missing batteries to electronic devices.
5. Changed Miner's disposable batteries to ones that fit the given charge.
6. Added police duty belt to Bionic Police Officer. I forgot to re-add the belt while fixing the chestrig in #33878. 😛
Describe alternatives you've considered
None.
Additional context
This fix would be considered a buff to many professions, due to the batteries being given for their devices.