Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font loading #37919

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Fix font loading #37919

merged 4 commits into from
Feb 17, 2020

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Feb 11, 2020

Summary

SUMMARY: Bugfixes "Fix font loading"

Purpose of change

Fixes #37916

Describe the solution

See commit messages.

Testing

Change in-game language to one using non-Latin alphabet (i.e. Russian, Chinese, Korean or Japanese) and see that font glyphs are displayed.

Additional context

  1. We can restore Terminus Bold font after changing its internal identifier (or make font style selection configurable)

  2. While working on this PR I've found out that some glyphs (like the ones with with cedilla) are not displayed properly when current Terminus font is used. I will fix it in a different PR.

Terminus:
image

Unifont:
image

@ZhilkinSerg ZhilkinSerg added SDL: Tiles / Sound Tiles visual interface and sounds. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 11, 2020
@ZhilkinSerg ZhilkinSerg linked an issue Feb 11, 2020 that may be closed by this pull request
@8street
Copy link
Contributor

8street commented Feb 12, 2020

Please merge it quickly.

@Funguss
Copy link
Contributor

Funguss commented Feb 12, 2020

There's a fonts.json in config, why didn't you use that? Also, I tried deleting the font and changing the json but I've still got terminus bold...

I dunno why people hate on the unifont, I happen to think it looks great. But I like single pixel width sans serif in general. Fancier fonts feel invasive for me, like I'm being told to interpret things in a certain way. In my current game I arrived at a post office I'd already cleared just before dawn and was imagining the sunrise and the cool spring air, how calm that moment would be. Then I met a wandering zombie security guard and casually speared him through a broken window. It felt relaxed, but this terminus bold would have stood in the way of that moment.

src/sdltiles.cpp Outdated Show resolved Hide resolved
src/sdltiles.cpp Outdated Show resolved Hide resolved
src/sdltiles.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg
Copy link
Contributor Author

I've self-merged it as it was kinda serious issue without progress for almost a week.

@ifreund ifreund mentioned this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
4 participants