Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'lumination' mutation value not using float #37843

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Fix 'lumination' mutation value not using float #37843

merged 1 commit into from
Feb 9, 2020

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Feb 8, 2020 •
edited
Loading

Summary

SUMMARY: Infrastructure "Made mutation 'lumination' value use proper type"

Purpose of change

It's stated as float in documentation, loaded as float from json and treated as float in character illumination calculation

Describe the solution

Make it actually be float

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) labels Feb 9, 2020
@ZhilkinSerg ZhilkinSerg merged commit 1ca4f95 into CleverRaven:master Feb 9, 2020
This was referenced Feb 9, 2020
Closed
Closed
@olanti-p olanti-p deleted the fix-mut-lum-float branch February 9, 2020 14:34
This was referenced Feb 16, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olanti-p @ZhilkinSerg