Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle construction does not accept wire #37970

Closed
Funguss opened this issue Feb 12, 2020 · 8 comments
Closed

Vehicle construction does not accept wire #37970

Funguss opened this issue Feb 12, 2020 · 8 comments
Labels
<Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding

Comments

@Funguss
Copy link
Contributor

Funguss commented Feb 12, 2020

A simple thing that has bugged me for years. When building a vehicle out of wire you first need to use a frame which you later deconstruct, as wire is not a valid component in the construction menu. This should be included in the recipe.

@Kilvoctu
Copy link
Contributor

@Soup-de-Loop as this is a vehicle part from blazemod.
Wire will need to be added as a possible component for "Start Vehicle Construction" by giving the wiring vehicle part the INITIAL_PART flag.

@Funguss
Copy link
Contributor Author

Funguss commented Feb 12, 2020

Ah, that so? Is blazemod no longer supported then?

@Kilvoctu
Copy link
Contributor

At the moment, blazemod is obsoleted, but it's being reworked by Soup in #37497 to be reborn after 0.E.

If you'd like to add this feature in the meantime, go to the blazemod folder and open blaze_other_parts.json. Then go down to the flags for "wiring". It'll say something like:
"flags": [ "FOLDABLE", "AISLE" ]
change it to
"flags": [ "INITIAL_PART", "FOLDABLE", "AISLE" ]

@Funguss
Copy link
Contributor Author

Funguss commented Feb 12, 2020

Ok, I thought "yeah, this is a simple fix, I should learn how to do a JSON PR at least" but I can't seem to find the tutorial. I'm pretty sure there's one out there? I don't suppose you have a link?

@Soup-de-Loop
Copy link
Contributor

I hear and obey, thank you for bringing this up- I thought I knew the flag to add, but it’s still a fantastic attitude to have and it helps relatively newbie contributors like me feel a little less stressed trying to figure out what needs to be done. Should be committed within the hour.

@anothersimulacrum
Copy link
Member

@Funguss You want this https://github.com/CleverRaven/Cataclysm-DDA/wiki/Guide-to-adding-new-content-to-CDDA-for-first-time-contributors

Soup-de-Loop added a commit to Soup-de-Loop/Cataclysm-DDA that referenced this issue Feb 13, 2020
Allows a vehicle to be started with just wiring, cutting out an extra step for vehicularised base building. From issue CleverRaven#37970
@Soup-de-Loop
Copy link
Contributor

Change pushed to the PR, thanks for bringing this up! 👍

@KorGgenT KorGgenT added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Mar 5, 2020
@Saicchi
Copy link
Contributor

Saicchi commented Dec 4, 2021

Is this issue still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Development

No branches or pull requests

7 participants