Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use text snippets for tutorial messages #37552

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Use text snippets for tutorial messages

Describe the solution

Rework tutorial messages to use text snippets infrastructure.

Testing

Try finishing a tutorial and make sure all text message are correct.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jan 30, 2020
@Night-Pryanik
Copy link
Contributor

I guess we need to separate tutorial messages for tiles and curses builds. All these "@ symbol is you" or "brown + next to you" could confuse new players and/or are useless when player is using tileset.

@ZhilkinSerg
Copy link
Contributor Author

I guess we need to separate tutorial messages for tiles and curses builds. All these "@ symbol is you" or "brown + next to you" could confuse new players and/or are useless when player is using tileset.

Yeah, tutorial definitely needs a rework.

@codemime
Copy link
Contributor

This distinction can't be bound solely to builds. Tiles builds feature console glyphs too.

@ZhilkinSerg
Copy link
Contributor Author

This distinction can't be bound solely to builds. Tiles builds feature console glyphs too.

Yes, texts should be either more generic or we can use different texts depending on state of tiles.

@ZhilkinSerg ZhilkinSerg force-pushed the tutorial-snippets branch 2 times, most recently from 9fa4eeb to 94912dd Compare January 30, 2020 21:14
@ZhilkinSerg ZhilkinSerg marked this pull request as ready for review January 30, 2020 21:15
@Qrox
Copy link
Contributor

Qrox commented Jan 31, 2020

We can draw highlight on the relevant tiles and change the texts to refer to the highlight instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants