Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change uncraft recipe for sandbag, and fix component quantity #38047

Merged
merged 7 commits into from
Feb 16, 2020

Conversation

NastyNate2612
Copy link
Contributor

@NastyNate2612 NastyNate2612 commented Feb 15, 2020

Summary

SUMMARY: Balance "change uncraft recipe for sandbag, and fix component quantity"

Purpose of change

I dont know, we need more sand i guess? sandbag should yield same amount of sand when you uncraft it as it holds, very easy IRL to cut open a sandbag and save all the sand, ive had to do it before when my sandbags keeping water from going under my house start to fall apart.
sandbag should be 3000 sand if u take into account the volume and weight of the other ingredient, canvas sack.

Describe the solution

change uncraft recipe for sandbag to 3000 sand , change required sand for sandbag recipe to 3000 units.

Additional context

This was brought up by a user on reddit, no issue was created so far so i made a PR to fix it

sandbag needed 3200 sand to craft. should be 60
@NastyNate2612
Copy link
Contributor Author

im looking for the item "sandbag" in the json files so i can change the weight for this item as well, some items are easier to find than others

@anothersimulacrum
Copy link
Member

One unit of sand is not 250ml
image
3200 sand is the correct amount for 16L
image

@NastyNate2612
Copy link
Contributor Author

image

then why does it say 250ml in the json file?

@anothersimulacrum
Copy link
Member

Because that's for 50 units of sand.

@NastyNate2612
Copy link
Contributor Author

oh ur right i didnt see the stack amount, says count instead.

@NastyNate2612
Copy link
Contributor Author

ahh ok so the problem isnt the crafting recipe, its the deconstruction recipe is way off
only gives back 60 sand

@NastyNate2612 NastyNate2612 changed the title fix sandbag recipe components make sandbag reversible Feb 15, 2020
@NastyNate2612 NastyNate2612 changed the title make sandbag reversible make sandbag reversible, and fix components Feb 15, 2020
if sandbag is 16L and canvas sack takes up 1L then 3000 sand would make 16L. I could change the weight back those couple hundred grams too on the sandbag if u all want to be super accurate and technical
changed from 60 sand to 3000 sand
@NastyNate2612
Copy link
Contributor Author

NastyNate2612 commented Feb 15, 2020

so after much thought i decided that reversible wouldnt be the right choice. So instead i found the uncraft recipe and raised the yield to 3000 sand because i believe you would be able to salvage most if not all the sand since ive done so myself irl. The amount of sand collected on disassembly would scale based on quality of the sandbag with this configuration right?

@NastyNate2612 NastyNate2612 changed the title make sandbag reversible, and fix components change uncraft recipe for sandbag, and fix component quantity Feb 15, 2020
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 16, 2020
@I-am-Erk I-am-Erk merged commit efad589 into CleverRaven:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants