Crash on start when SCALING_FACTOR option is 2 or 4

[drfloob]

The game crashes on start when SCALING_FACTOR option is 2 or 4.

Steps To Reproduce

1. Start the game
2. Set scaling factor to 2 or 4 in the Graphics Options menu
3. Quit and Restart the game.

Or alternatively set SCALING_FACTOR=2 in ~/.cataclysm-dda/config/options.json

Versions and configuration

Game was built from source with commit 01d82b3 (2020.02.15). Ubuntu 18.04
Game version according to the main menu: Cataclysm DDA version 0.D-12288-g01d82b3dfd
Graphics version: Tiles
No Mods.

Crash and Debug logs attached
cataclysm-crash-20200115_12288-g01d82b3dfd.tar.gz

[drfloob]

From the debug log attached above, the crux of the issue is:

src/options.cpp:613 [int options_manager::cOpt::value_as() const] DISPLAY tried to get integer value from option of type string_select

Also from my config:

{ "info": "Sets which video display will be used to show the game. Requires restart.", "default": "Default: 0 - Values: 0", "name": "DISPLAY", "value": "0" },

Somehow, treating this JSON "int" as an integer is causing the problem.

[drfloob]

It's due to this change 5 days ago: #37548 . The DISPLAY setting conceptually went from being an int to a string. I'll add a patch to get it working again, but it seems wrong that this option is both a string and an int, it should probably just be an int.