Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninterrupted Sleep on Death #37977

Closed
Willenbrink opened this issue Feb 12, 2020 · 6 comments · Fixed by #38663
Closed

Uninterrupted Sleep on Death #37977

Willenbrink opened this issue Feb 12, 2020 · 6 comments · Fixed by #38663
Labels
<Bug> This needs to be fixed (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Milestone

Comments

@Willenbrink
Copy link
Contributor

Willenbrink commented Feb 12, 2020

Describe the bug

Freezing to death does not interrupt sleep.
When sleeping the game will display "Wait till you wake up...". This message is displayed even after the death of the character (i.e. by freezing to death). In the log the last few displayed messages are:

...
Your head hurts!
Your head hurts!
Your head hurts!
Your limb breaks!

At this point the game continues simulating the environment but does not allow the player to interrupt this process forcing them to kill the process with SIGINT/SIGKILL (SIGTERM is ignored).

Steps To Reproduce

  1. Create new character.
  2. Take off all clothing
  3. Sleep
  4. Freeze to death and watch the simulation

Expected behavior

After dying the usual prompt "Watch your last moments etc." should be displayed.

Screenshots

ss

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: 1.0; Distributor ID: VoidLinux; Description: Void Linux; Release: rolling; Codename: void;
  • Game Version: 0.D-12149-g7a3893221e-dirty [64-bit] (unrelated changes)
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Graphical Overmap [Graphical_Overmap],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

When catching the common cold while sleeping the player wakes up due to coughing and does not die. Possibly a bug unexpected behaviour?

@KorGgenT KorGgenT added the <Bug> This needs to be fixed label Mar 5, 2020
@KorGgenT KorGgenT added this to the 0.E milestone Mar 5, 2020
@Fris0uman
Copy link
Contributor

Fris0uman commented Mar 6, 2020

Can't reproduce the bug:

Set season to winter
Drop cloth
Set fatigue to 999
Eat two codein for the pain
Go to sleep
Freeze to death
image

@Ramza13
Copy link
Contributor

Ramza13 commented Mar 7, 2020

Also could not reproduce. Created winter character waited till tired removed clothes slept, died and saw prompt.

@Night-Pryanik Night-Pryanik added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 8, 2020
@jkraybill
Copy link
Contributor

OK, so I can reproduce the exact scenario described here, IF Deathcam option is set to "Always". I apparently die in my sleep (I don't get a log message for that but can see head HP go to zero), and then the game keeps spinning indefinitely. @Willenbrink can you let us know if perhaps the Deathcam option had been inadvertently set to "Always"?

@jkraybill
Copy link
Contributor

Further repro: this also happens when manually entering deathcam. The issue is that the player never gets the below "Press ESC..." message when you die while asleep and then go to deathcam. I'll look and fix that issue if it's within my abilities.

image

@Willenbrink
Copy link
Contributor Author

The Deathcam option has been set to "Always" and I can not reproduce the bug when it's set to "Ask".

@jkraybill
Copy link
Contributor

@Willenbrink thanks for the confirmation -- the linked PR will definitely fix this when merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants