chemistry: extracts and concentrates pt2 #37944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds filter paper qualitative and quantitative, tool qualities, vac pump on/off, recovery pump, butane tank
|
Yay butane! |
curstwist
added
[JSON]
NastyNate2612
changed the title
This was referenced Feb 16, 2020
…y using ui_manager
Window manager for properly refreshing and resizing multiple layers of windows
Use ui_manager in main menu and related menus
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
924f105 to
39e00e3
Compare
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
ad63e77 to
8e68539
Compare
kevingranade
force-pushed
the
dev
branch
4 times, most recently
from
621a68e to
b7106d0
Compare
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
0f30a43 to
d432807
Compare
|
woohoo my contributions are getting merged! Ill probably have to change a few crafting recipes and stuff, but im ready to start working on it again. Thanks everybody for everything you do! |
|
hey so I noticed that there were a bunch of changes made to this PR that doesn't have to do with the content in here. Do i need to close out this PR and start a new one? If it wasnt for all the other changes done this PR should pass all checks at this point i believe. I could be wrong, this is my first set of PR's so im still learning how all this works. |
mlangsdorf
changed the title
|
Rebased and pushed as 2876ece |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds filter paper qualitative and quantitative, tool qualities, vac pump on/off, recovery pump, butane tank
Summary
SUMMARY: Content "3rd installment of my extracts and concentrates mod into mainline"
Describe the solution
-filter paper qualitative and quantitative: used in filtration with buchner flask to seperate solids from liquids (ill add byproduct solid for that soon)
-vac pump on/off: used in various recipes, needs to be on to operate
-recovery pump: required for closed loop extraction systems. similar function to a vacuum pump but can recover solvent without risk of explosion
-butane tank: used with closed loop extractors. (eventually ill add butane as an ammo source similar to "battery" (wont exist on tiles because its a gas) and then butane tanks will be able to be refilled)
-added item qualities to this PR. Whenever this one gets merged it should make parts 3-6 pass the checks.
TODO LIST: Add into item groups! Im not sure where all of the items i created should spawn so ill add that last as a part 7 when everyone is ready for the content to be merged
Testing
All items crafted and tested