Weekly Digest (12 April, 2020 - 19 April, 2020) #39724

weekly-digest · 2020-04-19T14:22:46Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 217 issues were created.
Of these, 153 issues have been closed and 64 issues are still open.

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

👍 #39564 melee: Make sure that melee weapon accuracy improves hit rates, by mlangsdorf
It received 👍 x13, 😄 x0, 🎉 x0 and ❤️ x5.

NOISY ISSUE

🔈 #39588 Place cursor at highlighted item name in construction and crafting menus as expected by screen readers, by Qrox
It received 13 comments.

PULL REQUESTS

Last week, 166 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 39 pull requests were updated.
💛 #39694 melee: make polearms do less damage against adjacent targets, by mlangsdorf
💛 #39676 Magiclysm: Added recipes for mana potions. Added lesser mana infusion. Tweaked the recipe for manatouched serum., by HarrisonGreenlee
💛 #39654 Polearm weapon balance (Part 6 of melee weapon balance project), by Brian-Otten
💛 #39650 Axe weapon balance (Part 4 of melee weapon balance project), by Brian-Otten
💛 #39649 Club weapon balance (Part 3 of melee weapon balance project), by Brian-Otten
💛 #39631 [WIP] bow itemization & progression improvements, by nphyx
💛 #39622 WIP: Change generic "shot" to 12 Gauge, by carmakazi
💛 #39582 Fan belt ballista, by OddSkollar
💛 #39573 Fix for AFS Mastadon: Mutations, by LaVeyanFiend
💛 #39561 Masochist mutation tree rework, by CodeBandit
💛 #39556 Remove RM99 caseless revolver, by tenmillimaster
💛 #39504 2StoryModern01 - rare house, by LilShiningMan
💛 #39492 Adds new barrel bombs. obsoletes old explosive charges., by Brian-Otten
💛 #39487 Converting Materials From Strings To Arrays, by klorpa
💛 #39485 Spaces Removal, by klorpa
💛 #39463 Add option for aim window position, by Kilvoctu
💛 #39454 Hacking stuff prerequisite - install software, by nphyx
💛 #39447 NPC traders, by Brytenwalda
💛 #39417 New pipe bombs, by Brian-Otten
💛 #39387 Prevent gaining non-intelligence stats from reading with Stats Through Skills, by anothersimulacrum
💛 #39370 Adds new grenades and recipes, by Brian-Otten
💛 #39300 Remove dangling references to leadworks, by anothersimulacrum
💛 #39297 Migrate ACT_PICKUP to the activity actor system, by ifreund
💛 #39239 [WIP] Naive first draft beginning bowyery overhaul, by OddSkollar
💛 #39210 Clothing mod expansion, by nphyx
💛 #38912 [CR] Add bullet damage type, by anothersimulacrum
💛 #38654 Airgun nerf & air cylinders, by misterprimus
💛 #38513 Premium survival kit, by Maleclypse
💛 #38449 Add butter to pie recipes., by sharkfinsouperman
💛 #37944 chemistry: extracts and concentrates pt2, by NastyNate2612
💛 #37908 WIP [Aftershock] Frankenstein NPCs, by Maleclypse
💛 #37497 Initial Blazemod re-work, by Soup-de-Loop
💛 #37399 Allow ammunition to burn and make small explosions with loud sounds, by SeventhSandwich
💛 #37377 [WIP] Lots more books, by Jerimee
💛 #36645 Tweaked zombie soldier, cop and survivor drop lists, by Night-Pryanik
💛 #36324 refresh look_around appearance, by captnblood
💛 #34667 Documentation for relic_data, by KorGgenT
💛 #32017 [WIP][CR] Provide point types with coordinate system type-safety, by jbytheway
💛 #32012 [WIP] Fix 3d shadowcasting, by ifreund

MERGED PULL REQUEST

COMMITS

Last week there were 302 commits.
🛠️ [Separate shelter types (#39427) * Initial test for new shelter type

Some more updates, unable to generate starting location still
Forgot to change the other weights
Working mapgen, removed extra roof overmap terrains
Linted json and removed extra shelter definitions.
Removed extra name definition](5738946) by kevingranade
🛠️ [Lock picking overhaul (Lock picking overhaul #39409) * Added lock picking skill
Use lock picking skill in calculation of success when picking the lock of doors and gun safes
Gave several professions lockpicking as a starting skill
Added a booklet about lockpicking
Added lockpicking booklet to several books item groups
Added doxygen documentation for the new skill
Added lockpicking quality to several items
Updated hardcoded lockpicking qualities for gun safe lockpicking
Made lockpicking long activity
Added gun safe to the list of furniture in mapdata
Made lockpicking activity recognize furniture (gun safe in particular)
Removed mentions of now-unused gunsafe_ml examine function](1870fbb) by Night-Pryanik
🛠️ fix necropolis spawn by curstwist
🛠️ Merge pull request #39646 from ifreund/activity-actor-start Add a start function to activity_actor and migrate ACT_HACKING by kevingranade
🛠️ Remove some unused coordinate_conversion functions Remove all the ones taking separate int arguments and returning a new point. Callers of these have all been converted to use the point versions, so these can now be removed. Except that the point versions were still written in terms of them, so those needed tweaking. by jbytheway
🛠️ Port function implementations by jbytheway
🛠️ Port call sites by jbytheway
🛠️ basement variety 5 5 houses, 10x10 set of gun basement nests. by curstwist
🛠️ Add more overloads taking point arguments by jbytheway
🛠️ Port implementations of changed functions by jbytheway
🛠️ melee: update the docs for the changes Include the Melee Evaluation spreadsheet and a description of it, and update GAME_BALANCE.md with the new formulas. by mlangsdorf
🛠️ NPCs: use effective dps for melee_value() use average of effective dps against evaluation monsters in melee_value(), with an additional bonus for reach weapons and for weapons that work with a martial art the NPC knows. by mlangsdorf
🛠️ item: improve the effective dps display Don't calculate dps for monsters that aren't going to be displayed. Adjust the unit tests based on relative values (epsilon) instead of fixed values (margin). by mlangsdorf
🛠️ melee: make sure that accuracy increases hit rates Move the accuracy bonus out of the avatar's hit bonuses where they may or may not be set correctly via reset() and into get_hit_weapon() where they are definitely set and applied correctly. Add some statistics counters to the melee code to make writing test cases easier. Add unit tests to verify that increase a weapon's accuracy increases to hit rates and DPS. by mlangsdorf
🛠️ melee: clean up the code slightly Fix some long lines and use std:: functions in place of math.h functions in a few places. by mlangsdorf
🛠️ melee: actually call get_melee_hit_base() commit 8ef3706eaa9 moved a bunch of melee related functions out of player:: and into Character::, but failed to call the new renamed version of get_hit() correctly. by mlangsdorf
🛠️ Improve DPS trials with better re-initialization Results are closer to expectations now, though not quite there yet. ex. trench knife vs. debug monster: Actual 13.0157, Expected 20.160 by wapcaplet
🛠️ Add tests for damage per second by wapcaplet
🛠️ Port callers by jbytheway
🛠️ Add unit tests for melee dodge and hit functions Includes new unit tests for Character, player, and monster functions get_hit_base, get_dodge_base, and get_dodge. by wapcaplet
🛠️ Fix and improve player helpers Use dummy.setpos instead of g->u in the place_player helper function. Global g->u avatar instance is implicit in place_player; we want to set the position of the dummy instance, not necessarily g->u. Also reset speed and bonuses in clear_character. by wapcaplet
🛠️ [Add growable popcorn and horseradish (Add growable popcorn and horseradish #39376) * Add growable popcorn and horseradish
Adjust horseradish fun value
Fix JSON style
Try to fix comestible tests
Fix calories and vitamins for greens](074dd18) by Rail-Runner
🛠️ Merge pull request #39665 from Soup-de-Loop/soupdeloop-blazemod-PR3 Blazemod Mini-PR: Removes turretframe by ZhilkinSerg
🛠️ Merge pull request #39682 from Soup-de-Loop/soupdeloop-blazemod-PR10 Blazemod Mini-PR: Remove glowie dependent generator and battery by ZhilkinSerg
🛠️ Merge pull request #39670 from Soup-de-Loop/soupdeloop-blazemod-PR6 Blazemod Mini-PR: Modernises blob_turret_mount and adds blob_turret abstract by ZhilkinSerg
🛠️ [Blazemod Mini-PR: Revise blob "frostie" vehicle parts and items (Blazemod Mini-PR: Revise blob "frostie" vehicle parts and items #39684) * re-add old frostie "sea wheel" for context

restores the old and redundant frostie_wheel_sea to provide context for the replacement in the following commit

repurpose frostie wall and sea wheel

changes the ID and revises the frostie_wall vehicle part into a functional windshield and converts the ancient "boat wheel" into a usable boat hull, modernising some elements in the process

remove redundant item

no reason at current for the frostie_hull item to appear, particularly when there's been no way to obtain for some time now](2f131c4) by Soup-de-Loop
🛠️ [Blazemod Mini-PR: Modernise glowie and blob lights (#39681) * regenerate glowie

Rather than just add the new one, I've placed the old glowie here for future context as I missed it during the refactor.

update glowie

New version of glowie which is no longer a battery, as this translates poorly into other car parts such as lights with vehicle code in its current iteration. Plans to make different battery item/part for blob later.

modernised and rename gel_lamp

Gives blob vehicles access to blob versions of each different kind of vehicle light, while also using modern json conventions to reduce the amount of bloat and make additions and reading easier.](7c4f966) by Soup-de-Loop
🛠️ Merge pull request #39679 from Soup-de-Loop/soupdeloop-blazemod-PR8 Blazemod Mini-PR: Modernises blob treads by ZhilkinSerg
🛠️ Merge pull request #39669 from Soup-de-Loop/soupdeloop-blazemod-PR5 Blazemod Mini-PR: minor change to blob construction ID's by ZhilkinSerg
🛠️ Merge pull request #39659 from Soup-de-Loop/soupdeloop-blazemod-PR1 Blazemod Mini-PR: Remove redundant blazemod turrets by ZhilkinSerg
🛠️ [Fix almost instantaneous and always successful climbing the downspouts (#39635) * Increased time cost to climb the unstable terrain (like downspouts)

Also added a chance to slip while climbing this terrain

Extracted slip_down function](cc1c14d) by Night-Pryanik
🛠️ Merge pull request #39667 from Soup-de-Loop/soupdeloop-blazemod-PR4 Blazemod Mini-PR: move bfeed to blob-specific file by ZhilkinSerg
🛠️ Merge pull request #39678 from ZhilkinSerg/android-2020-04-18 Update Android precompiled dependencies (2020-04-18) by ZhilkinSerg
🛠️ Merge pull request #39668 from BrettDong/i18n Routine i18n updates on 18 Apr 2020 by ZhilkinSerg
🛠️ Merge pull request #39680 from CountAlex/electric_shears Remove underscore for electric shears names. by ZhilkinSerg
🛠️ Add some point overloads by jbytheway
🛠️ Migrate game::look_around to ui_adaptor by Qrox
🛠️ Migrate zone manager to ui_adaptor by Qrox
🛠️ Fix refreshing when opening menus during activities by Qrox
🛠️ [Add enchantments to bionics (Add enchantments to bionics #39563) * Add enchantments to bionics
test json
update cache
move recalculate_enchantment_cache()
update force_add to consider emitter and ench_effects
Revert "test json"

This reverts commit 7ce05e0.

Jsonize bionic invisibility effect with an enchantment
Doc
fix

Co-authored-by: KorGgenT [email protected]](f94cfe1) by Fris0uman
🛠️ remove glowie dependent generator and battery Non-functional even with the glowie battery in its previous state, plans to re-implement in the future hopefully, perhaps differently. by Soup-de-Loop
🛠️ Remove underscore for electric shears names. by CountAlex
🛠️ modernises blob treads and makes them consistent within the mod's own content specifically expanding the requirements so that installation and removal isn't instantaneous, increasing the folding volume from a mere 250mL (to be reviewed) and making the durability depend on the tier of tread by Soup-de-Loop
🛠️ Add docs for activity_actor::start by ifreund
🛠️ Migrate ACT_HACKING to the activity actor system by ifreund
🛠️ Merge pull request #39660 from LyleSY/patch-7 [DinoMod] Add Dimorphodons to parks by ZhilkinSerg
🛠️ [[DinoMod] Add new dinos to hatchling group (#39656) * [DinoMod] Add Dimorphodon to hatchling group

Adds dimorphodon as a possible option if a random dino hatchling is spawned. Linted.

[DinoMod] Pachycephalosaurus hatchling bookkeeping

Match quality color](7d57d08) by Pupsi-Mupsi
🛠️ [Cave jsonify (Cave jsonify #39610) * Created json-variants of above-ground and underground sections of cave location and made it spawn
Removed hardcoded cave mapgen](086d751) by Night-Pryanik
🛠️ Merge pull request #39620 from ralreegorganon/fix-item-group-charges Fix items spawning with fewer charges than defined in their item group entry by ZhilkinSerg
🛠️ Merge pull request #39619 from wapcaplet/fix-lang-compiler Use correct sh syntax for string comparison by ZhilkinSerg
🛠️ Merge pull request #39609 from Qrox/doc-accessibility Add documentation on interface accessibility by ZhilkinSerg
🛠️ Merge pull request #39615 from Arcangelus/patch-1 Update armor.json by ZhilkinSerg
🛠️ Blazemod re-work preparatory restructure (#39621) by Soup-de-Loop
🛠️ Merge pull request #39624 from Drewscriver/master Remove WAIST tag from utility vest by Rivet-the-Zombie
🛠️ Add prices to vehicle parts by Brian-Otten
🛠️ Prices for tools by Brian-Otten
🛠️ Fix item_modifier charges when min and max are same by ralreegorganon
🛠️ Remove WAIST tag from utility vest Based on the item description, this would not be worn on the waist. by Drewscriver
🛠️ Use correct sh syntax for string comparison by wapcaplet
🛠️ Adds post apoc prices to resources by Brian-Otten
🛠️ Update armor.json Fixed typo by Arcangelus
🛠️ Adds postapoc prices to magazines by Brian-Otten
🛠️ more prices by Brian-Otten
🛠️ Add documentation on interface accessibility by Qrox
🛠️ Additional changes to windows terrain (#39527) by TheGoatGod
🛠️ Obsolete scrap weapons (#39438) by kevingranade
🛠️ basement variety 3 (#39595) by curstwist
🛠️ Merge pull request #39594 from Hymore246/EZBO-name-fix Elite Zombie Bio-operator name format fixed by ZhilkinSerg
🛠️ Merge pull request #39585 from Qrox/curses-ui-fixes Some curses UI fixes by ZhilkinSerg
🛠️ Merge pull request #39601 from wapcaplet/ants-alike Spawn regular ants under regular anthills by ZhilkinSerg
🛠️ Merge pull request #39596 from Pupsi-Mupsi/PB-BSC Surgical scalpels CBM changes by Rivet-the-Zombie
🛠️ [Improve json linter log readability (Improve json linter log readability #39597) * feat: make json linter log easier to understand
fix: fix astyle formatting in json formatter >.<](d67db55) by nphyx
🛠️ Merge pull request #39590 from ZhilkinSerg/enum-classes-2020-04-14 Enum classes by kevingranade
🛠️ Remove prop_damage from islot_ammo (#39600) by anothersimulacrum
🛠️ [Move melee related functions from player to Character (Move melee related functions from player to Character #39404) * Move block_hit(), and associated functions, from player to Character
Move apply_damage, deal_damage and related functions
fix
astyle
remove excedent slime](8ef3706) by Fris0uman
🛠️ remove + by Pupsi-Mupsi
🛠️ Modify to_hit by Pupsi-Mupsi
🛠️ Use correct z-level for ant check The existing i.pos in this loop has no z-level, so the check for whether tripoint_above was an anthill was looking at z+1, and there are no anthills in the sky, therefore all underground ants were spawning as acid ants. This commit uses the correct z-level, allowing normal ants to spawn in normal anthills. This commit also stores the calculated tripoint with correct z-level in a variable p_loc, then re-uses that in the three places that need it. by wapcaplet
🛠️ Add SPEAR flag to match regular scalpel by Pupsi-Mupsi
🛠️ Add to_hit, cutting and techniques by Pupsi-Mupsi
🛠️ Remove table buff/debuff for medicine by wapcaplet
🛠️ Minor fix by Pupsi-Mupsi
🛠️ Add description to bio_scalpel by Pupsi-Mupsi
🛠️ Add BIO-TOGGLED and BIO-WEAPON to bio_surgical_razor by Pupsi-Mupsi
🛠️ Elite Zombie Bio-operator name fix Updated EZBO name with proper formatting. by Hymore246
🛠️ Remove modularvest items by ymber
🛠️ Add grenade belts to loot pool by Brian-Otten
🛠️ Merge pull request #39588 from Qrox/ui-place-cursor Place cursor at highlighted item name in construction and crafting menus as expected by screen readers by ZhilkinSerg
🛠️ bearings recipe metal requirements (#39583) by Hirmuolio
🛠️ Merge pull request #39587 from Qrox/remove-unused-header Remove unused header from HeaderGuardCheck.cpp by ZhilkinSerg
🛠️ Make hint_rating a class enum by ZhilkinSerg
🛠️ Make text_alignment a class enum by ZhilkinSerg
🛠️ Make do_activity_reason a class enum by ZhilkinSerg
🛠️ Move function declarations out of function block by Qrox
🛠️ Place cursor at item names in construction and crafting menu as expected by screen readers by Qrox
🛠️ Remove unused header from HeaderGuardCheck.cpp by Qrox
🛠️ Avoid re-entry into game::init_ui from encoding checking by Qrox
🛠️ Avoid re-entry into game::init_ui from intro by Qrox
🛠️ Do not return from input_manager::get_input_event when resizing by Qrox
🛠️ Only show locale warning once by Qrox
🛠️ [Dark Skies: New Order Remaster (Dark Skies: New Order Remaster #39575) * merge files

merges neworder_misc and neworder_highorder. no reason for these to be seperate.

obsoletes weapons and armor

this reflects making the Order more alien. there will still be chances to make armor from alien metal.

adds a few new Order monsters

and removes the old ones. initial order monsters revolve around augmenting the existing struggle with Strays and bandits.

survelliance drones make a lot of light and make night raids a bit harder. one day they might be able to summon enemies, like eyebots.

seekers make bad situations worse, attempting to 'incapacitate' you with shocks and tools while you're wounded.

gives seekers more interesting attacks

allows it to blind as well as slash to not only break less of a one trick pony

tweaks emissary spawns

makes more dangerous ones spawn a bit later in towns

lints neworder_loworder
moves plague emissaries to forest spawns

they are intended to be hunting the player and other NPCs rather than being science units like base emsisaries, or exterminators like flame emissaries.

fixes emissary guns

Gas guns don't do direct damage. The emissary of flame doesn't wildly overshoot every time.

makes emissaries neutral towards strays

they don't care that they're infesting the towns - perhaps even the opposite. eventually emissaries of flame will cook wandering strays but not crystal masses.

Update mongun.json

upon testing: if damage is 0 it won't fire a projectile to drop the payload on someone. alternatives are using spells (good but doesn't have a warmup period) or making the damage type 'biological' to reflect a gas attack (biological damage is not resisted by anything so that feels crappy)

makes science emissaries more neutral

"basic" emissaries are more science-focused. they will attack if they think they can capture the player easily (player is weak) or if the player is hanging around them too much, but will otherwise have a higher tolerance for them being around.

fixes damage_type

I've been playing too much mount and blade apparently](b793146) by ephemeralstoryteller
🛠️ [Fix for AFS Mastodon: Items (#39571) * Move Uplifted SWAT gear to correct file & correct names

Fix mastadon mutagen being mi-go targeted](c9541e6) by LaVeyanFiend
🛠️ Merge pull request #39554 from Brian-Otten/40mm-ammo-effects Adds unique ammo effects to launcher ammo by Rivet-the-Zombie
🛠️ Obsolete sewer brew and tainted tornado (#39534) by LaVeyanFiend
🛠️ Merge pull request #39576 from jbytheway/detect_bad_rng_seeding Add clang-tidy check to catch incorrect use of RNGs by kevingranade
🛠️ Fix test for function namespacing by kevingranade
🛠️ Merge pull request #39510 from ZhilkinSerg/enum-classes-2020-04-11 Enum classes by kevingranade
🛠️ Add a clang-tidy check for misuse of random We need to ensure that all use of random number generators uses the common tools in rng.h in order to get reproducible test results. Add a clang-tidy check for misuses. by jbytheway
🛠️ Suppress some acceptable random engine uses by jbytheway
🛠️ Port some code using other RNGs to standard ones Various places in the codebase were not using the standard randomness as intended, which might lead to non-reproducible test failures. Rewrite them to do so. Throw in a litle refactoring at the same time. by jbytheway
🛠️ Rewrite condition to satisfy static analysis cur_npc is null exactly when stationed_npcs is empty. Writing it this way makes clang-tidy happier. by jbytheway
🛠️ Appease CI by Brian-Otten
🛠️ Merge branch 'master' into enum-classes-2020-04-11 by kevingranade
🛠️ Merge pull request #39559 from Miner239/patch-1 Make moss plowable by ZhilkinSerg
🛠️ Merge pull request #39569 from ralreegorganon/macos-brew-gettext Update handling of gettext via Homebrew on macOS by ZhilkinSerg
🛠️ Merge pull request #39469 from Qrox/migrate-ui-6 Migrate extended description, faction manager, and faction camp job/worker assignment UI to ui_adaptor by ZhilkinSerg
🛠️ Added more plastic items to the plastic chunk recipe and consolidate recipes (#39460) by thickmilk
🛠️ Add AK-47 semi-auto rifle, Mini Draco pistol, AK magazines (#39041) by carmakazi
🛠️ [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession (#37660) by Maleclypse
🛠️ [[DinoMod]Add monster Pachycephalosaurus ([DinoMod]Add monster Pachycephalosaurus #39486) * [DinoMod]Add monster Pachycephalosaurus

New content, adds egg laying and rideable Pachycephalosaurus, tougher and less common than gallimimus

Linted
Added pachycephalosaurus egg

Required for the new pachycephalosaurus monster to not break Dino Mod. Linted.

Added dimorphodon eggs

Needed another edit to reset the tests now that they're working. Added dimorphodon eggs to set up egg laying for that monster. Linted.

corrected name of dimorphodon egg to match

corrected copy-paste error](acedd25) by LyleSY
🛠️ Use namespaced math functions (#39553) by kevingranade
🛠️ Merge pull request #39566 from Qrox/fix-use-amount-crash Fix a crash in item::use_amount by ZhilkinSerg
🛠️ [Clang-tidy fixes (#39562) * Use point_zero

Un const parameters in function declarations](bd43707) by kevingranade
🛠️ Merge pull request #39568 from Fris0uman/blb_lint Lint tile_config for BLB by ZhilkinSerg
🛠️ Update handling of gettext via Homebrew on macOS by ralreegorganon
🛠️ Replace my_mutations with get_mutations where possible (#39531) * Replace my_mutations with get_mutations where possible and kill some auto by Fris0uman
🛠️ Lint tile_config for BLB by Fris0uman
🛠️ Suffix to prefix by Brian-Otten
🛠️ Fix a crash in item::use_amount by Qrox
🛠️ Merge pull request #39452 from jbytheway/cata_header_guard_check Add clang-tidy header guard check by kevingranade
🛠️ Make moss plowable by Miner239
🛠️ Merge pull request #39555 from Fris0uman/laser_ligth Lasers don't light up their path by ZhilkinSerg
🛠️ Lasers don't light up their path by Fris0uman
🛠️ new char popup edit boxes (#39467) by KorGgenT
🛠️ Fix unmountable turret bug (#39552) by OddSkollar
🛠️ [Add achievements tab to score window (Add achievements tab to score window #39540) * Support PREV_TAB, NEXT_TAB in scores window
Add achievements tab to scores window

Want the player to be able to see the achievements they are working
towards.

Add achievements text unit test](06514d0) by jbytheway
🛠️ Obsolete trigger happy trait (#39493) by ymber
🛠️ add more basement variety (#39528) by curstwist
🛠️ [Matchbox fix (Matchbox fix #39551) * Add extremely minimal item group test
Make ammo_set() accept both forms of null
More item group tests](a95b583) by kevingranade
🛠️ Fixes, range increases by Brian-Otten
🛠️ fixes by Brian-Otten
🛠️ Merge pull request #39490 from KorGgenT/split-adv-inv-display split advanced_inventory::display() into smaller functions by kevingranade
🛠️ Unique ammo effects by Brian-Otten
🛠️ Adding compound crossbow to itemgrups (#39550) Added compcrossbow to archery, with weight of 10. Reduced weight of crossbow by same amount (now 70) so that the distribution of items remains undistubed.
Added compound crossbow to home_display_case with weight 20. by Arcangelus
🛠️ remove unused variable by KorGgenT
🛠️ Merge pull request #39536 from Pupsi-Mupsi/PM-mmn Add makeshift_machete to ninjutsu by Rivet-the-Zombie
🛠️ Convert trailheads to overmap specials by ralreegorganon
🛠️ Merge pull request #39535 from jbytheway/test_fixes_2 Assorted test fixes 2 and mutation code cleanup by kevingranade
🛠️ Removed all instances of GROUP_ROTTING_PLANT by Night-Pryanik
🛠️ Adds prices to other half of comestibles. by Brian-Otten
🛠️ Don't call clear_mutations from player constructor Calling it leads to a lgtm warning, because it indirectly calls a virtual function. And it shouldn't do anything anyway; there's no way mutations could exist at this point in the constructor. by jbytheway
🛠️ mutation_(loss_)effects inside (un)set_mutation Each called of set_mutation or unset_mutation had to remember to call mutation_effects or mutation_loss_effects. Many of them weren't. It seems more logical to move that requirement inside (un)set_mutation. This probably fixes some bugs, although it doesn't seem to affect the tests. by jbytheway
🛠️ Rename empty_traits to clear_mutations In common C++ libraries, empty is an adjective, not a verb. by jbytheway
🛠️ Rewrite Character::empty_traits This wasn't calling all the code that is needed when toggling traits. Remove traits via the toggle_trait function instead to ensure it behaves like normal trait removal. by jbytheway
🛠️ Refactor Character::unset_mutation Rearrange the code for two reasons: - Avoid the weird else { return; } block. - Avoid a potential dangling reference if the argument is a reference into the my_mutations container. by jbytheway
🛠️ Rewrite Character::toggle_trait It could use a dangling reference when its argument was a reference into a container it erased from, leading to strange behaviour. Fix that by making a copy. Also, verify that the traits and mutations containers remain in sync as they are toggled. by jbytheway
🛠️ Report size category in starve_test To aid debugging. by jbytheway
🛠️ Simplify Character::height This function was overly complicated and had corner-cases which did the wrong thing. Make it much simpler. by jbytheway
🛠️ Also clear items in clear_map Failing to do so could break the crafting tests because extra items might be available for crafting nearby, thus causing the crafting code to need to ask the player which one to use (which triggers UI code which aborts in test mode, since there's no UI). by jbytheway
🛠️ Dedupe clear_vehicles code in map_helpers There were two implementations of vehicle clearing in map_helpers.cpp. Refactor them into a single implementation. by jbytheway
🛠️ Reset activity level in clear_character Not doing so affects the starvation tests. by jbytheway
🛠️ Normalize stomach contents in clear_character by jbytheway
🛠️ Report turns taken in "tools use charge to craft" by jbytheway
🛠️ Merge remote-tracking branch 'upstream/master' by Competently-Incompetent
🛠️ Merge pull request #39537 from jbytheway/remove_travis_clang_tidy Remove Travis clang-tidy job by kevingranade
🛠️ Merge remote-tracking branch 'upstream/master' by Competently-Incompetent
🛠️ Adds post apoc prices to first half of comestibles. (part 8 of reworking all prices) (#39518) by Brian-Otten
🛠️ Make direction a class enum by ZhilkinSerg
🛠️ Remove clang-tidy time limit GitHub has a much more generous time limit, so we should no longer need this 15 minute limit on clang-tidy jobs. by jbytheway
🛠️ Remove clang-tidy job from Travis We have one on GitHub now, which should be better due to a longer timeout. by jbytheway
🛠️ Update data/json/mutations/mutations.json Co-Authored-By: Anton Burmistrov [email protected] by Competently-Incompetent
🛠️ Merge remote-tracking branch 'upstream/master' by Competently-Incompetent
🛠️ Add makeshift_machete to ninjutsu by Pupsi-Mupsi
🛠️ Fixes Frost Armor spell from Magiclysm mod by VitorHP
🛠️ Report clang-tidy issues on tools headers by jbytheway
🛠️ Fix header guards in tools dir by jbytheway
🛠️ Suppress header guard in version.h by jbytheway
🛠️ Suppress guard change for catch.hpp We don't want to change the header guard for catch.hpp. by jbytheway
🛠️ Apply header guard fixes by jbytheway
🛠️ Custom header guard check Write a check to verify that our header guards follow a consistent style. by jbytheway
🛠️ Merge remote-tracking branch 'upstream/master' by Competently-Incompetent
🛠️ Merge pull request #39466 from Brian-Otten/post-apoc-price-controls-7 Changes prices on all books (part 7 of reworking all prices) by Rivet-the-Zombie
🛠️ Merge pull request #39505 from Night-Pryanik/minefields-spawn-fix Minefields spawn fix by kevingranade
🛠️ Make combat_engagement, aim_rule, cbm_recharge_rule and cbm_reserve_rule a class enums by ZhilkinSerg
🛠️ Make affected_stat a class enum by ZhilkinSerg
🛠️ Make radio_type a class enum by ZhilkinSerg
🛠️ Make add_type a class enum by ZhilkinSerg
🛠️ Make available_status and component_type a class enums by ZhilkinSerg
🛠️ Make character_type a class enum by ZhilkinSerg
🛠️ Merge remote-tracking branch 'upstream/master' by Competently-Incompetent
🛠️ Removed unused using by ZhilkinSerg
🛠️ Updated check to pass test by Night-Pryanik
🛠️ Shorter keybindings info + move age and height (#39433) by Pupsi-Mupsi
🛠️ Craftable hotdogs (#38219) by Maleclypse
🛠️ Merge pull request #39515 from Maleclypse/Prepnet-Aggro-corrections [Aftershock] Prepnet uses Monfaction hate now by ZhilkinSerg
🛠️ Update Migo mutation line (#39432) by Maleclypse
🛠️ Merge pull request #39483 from curstwist/basement-variety-1 add nested basement maps by ZhilkinSerg
🛠️ Merge pull request #39203 from kevingranade/returne-archery-balance Drop archery damage by 5x and increase archery crit damage by 5x by ZhilkinSerg
🛠️ Merge pull request #39511 from ralreegorganon/weighted-nested-mapgen Use weighted list for nested mapgen with same id by ZhilkinSerg
🛠️ Merge pull request #39520 from anothersimulacrum/astyle Fix astyle regressions by ZhilkinSerg
🛠️ Fix astyle regressions by anothersimulacrum
🛠️ Use weighted list for nested mapgen with same id by ralreegorganon
🛠️ batch time savings for wild veggies (#39500) by Aluminumfoil
🛠️ Astyle by Night-Pryanik
🛠️ Merge pull request #39477 from ZhilkinSerg/translations-2020-04-11 Utilize translation class instead of using raw strings by kevingranade
🛠️ Returned back "mx_minefield theoretical spawn" test case with updated conditions by Night-Pryanik
🛠️ Merge pull request #39478 from jbytheway/clang_tidy_github_workflow Create a GitHub workflow for running clang-tidy by kevingranade
🛠️ Merge pull request #39494 from jbytheway/fix_static_translations Don't perform translations at initialization by kevingranade
🛠️ Merge pull request #39513 from jbytheway/assorted_test_fixes Assorted test fixes by kevingranade
🛠️ [Fix invalid item placement error (Fix invalid item placement error #39497) * Simplify debugmsg with tripoint::to_string
Suppress some out-of-bounds placement warnings

Sometimes items from smashed car pieces are placed outside of the map
bounds during mapgen. There doesn't seem to be a reasonable way to
prevent this, so just suppress the error message in the cases it is
expected to occur (the item position was already being clamped to the
valid bounds).

CONTRIBUTORS

Last week there were 40 contributors.
👤 kevingranade
👤 Night-Pryanik
👤 curstwist
👤 jbytheway
👤 mlangsdorf
👤 wapcaplet
👤 Rail-Runner
👤 ZhilkinSerg
👤 Soup-de-Loop
👤 Qrox
👤 Fris0uman
👤 CountAlex
👤 ifreund
👤 LyleSY
👤 Pupsi-Mupsi
👤 Drewscriver
👤 Brian-Otten
👤 Ramza13
👤 ymber
👤 CodeBandit
👤 KorGgenT
👤 BrettDong
👤 Rivet-the-Zombie
👤 anothersimulacrum
👤 Arcangelus
👤 ralreegorganon
👤 TheGoatGod
👤 nphyx
👤 Hymore246
👤 Hirmuolio
👤 ephemeralstoryteller
👤 LaVeyanFiend
👤 thickmilk
👤 carmakazi
👤 Maleclypse
👤 Miner239
👤 OddSkollar
👤 Competently-Incompetent
👤 VitorHP
👤 Aluminumfoil

STARGAZERS

Last week there were 13 stagazers.
⭐ marcelmaatkamp
⭐ LyleSY
⭐ JonathanCLo
⭐ nniixxoossccnn
⭐ aplegatt
⭐ Ofthefog
⭐ rgoliveira
⭐ Fanxiaotong9607
⭐ foverzar
⭐ huangjunxin
⭐ nekoppoituki
⭐ yimogod
⭐ NeedFI
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Apr 19, 2020

ZhilkinSerg closed this as completed Apr 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (12 April, 2020 - 19 April, 2020) #39724

Weekly Digest (12 April, 2020 - 19 April, 2020) #39724

weekly-digest bot commented Apr 19, 2020

Weekly Digest (12 April, 2020 - 19 April, 2020) #39724

Weekly Digest (12 April, 2020 - 19 April, 2020) #39724

Comments

weekly-digest bot commented Apr 19, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES