-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots more books #37377
Lots more books #37377
Conversation
try to fix how I've tangled up my git
novel_pulp_squids
move items/classes/book.json to items/book/abstract.json
changes times to strings and other misc typos
move book abstracts over that were previously in folder classes
…m-DDA into more-paperbacks
fix nonfiction to conform to string (time: 20 m NOT time: 20)
FIX MISTAKE: this pr shouldn't alter bashing.json
add abstracts to cooking
update spiritual.json with holybook_satanic
This PR has become unwieldy - can be merged as is? If not, I think I need to close it and then break it down into distinct parts so that it is easier to discuss, test, and merge. The impact in-game will be that there are more clutter paperback books, particularly in those spawning from SUS itemgroups. The bigger impact is the changes to the organization and taxonomy for book json and SUS library. Hopefully what I've done here makes the desired organization clear. |
update spiritual.json in the hopes that clang-tidy will take pity on me
We just need to fix some minor formatting issues reported in (double spaces and such). Can be handled while mergetesting. |
Summary
SUMMARY: Content "lots more books"
Purpose of change
This request
Describe the solution
Uh, in no particular order:
Describe alternatives you've considered
occult books added to misc
I added two "occult paperbacks" on the Church of Subgenius. Church of Subgenius is an existing entity within CDDA, and the books are loyal to that faith tradition, meaning that they are inherently nonsensical in nature.
The third paperback references The Church of Starry Wisdom, and I didn't want to compromise existing lore; so this book is purposefully portrayed as an unreliable source of info.
added new file spiritual.json
spiritual.json could perhaps be better named holy.json or inspirational.json. The former due to the subject matter, naming convention, and presumably intent. The later due to the flag. "Spiritual" is useful because of the trait.
OC vs IRL
I added fiction books that were of my own made creations, and I also added famous real novels. The file already included dozens (hundreds?) of titles of real novels. Do we have a preference for real world content vs OC? Is having a mix of both problematic?
Organization
I organized content first as fiction or nonfiction, and then by type (paperback or hardback mostly, but there are others printed materials too).
This was only semi-intentional, and stems from the convention that skill training books tended to be nonfiction and hard backs, whereas non-skill books (ie., books for fun, clutter books, books for lore) tended to be fiction and have physical stats suggesting paperback. Regardless of the merits of one taxonomy decision vs another, it is better to have content organized than not. I'm not wedded to my scheme, but I do wish to continue to organize this content so that it is convenient.
I hope to add at least a dozen hardback fiction books for variety. These will take up significantly more inventory space. However this PR does not include that. Additionally, I hope to add dozens of nonfiction titles that are not skill books. This PR does not include those.
The homemaking category might be a tad sexist. These are books about gardening, beauty, entertaining, and home decor. It isn't visible in game however, and I don't want to further complicate this request.
library.json
The extensive "cascading" set of tables added to SUS/library.json violates the letter of that project, but conforms to the spirit of it. The single tables are not meant to reflect a specific piece of furniture, and are meant to facilitate that admirable goal.
misc
Some things I wanted to do but resisted the impulse:
Testing
TODO
Additional context
I tangled up my master branch, so there are some unrelated files here. It doesn't look like anything problematic and it is unintentional.
"Buzzards Bay" with no apostrophe is not a typo; BB is off the coast of Rhode Island and Mass and I triple checked the spelling.
I could not get the time parameter to function correctly as a relative value. A guess is this might be a fault of the abstract uses a string and my instance used an integer? I side stepped this by just taking it out of the relative (defining it explicitly).
While I was looking into giving occult books INSPIRATIONAL flags I discovered that Spiritual is multiplicative, but nearly every book flagged has fun 1 so that is irrelevant. The priest_diary has fun: -1, meaning that a Spiritual character will find priest diary three times as boring as a non Spiritual character - clearly a bug. This should be addressed, but is outside the ever-expanding scope of this PR.
Future plans
Once I've added a greater variety of books, I intend to take a look at book stores and libraries to see if I can improve those locations with both more and better organized books.