Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots more books #37377

Merged
merged 86 commits into from
May 7, 2020
Merged

Lots more books #37377

merged 86 commits into from
May 7, 2020

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Jan 25, 2020

Summary

SUMMARY: Content "lots more books"

Purpose of change

This request

  • adds a number of new books and book abstracts,
  • reorganizes book/misc.json,
  • adds book/spiritual.json and moves those books from misc.json,
  • and adds new content to loot tables as appropriate.

Describe the solution

Uh, in no particular order:

  1. add "copy-from": "paperback_novel" to novel_satire and novel_crime (and made associated adj)
  2. correct an accidental change to novel_horror (from Paperback novel tpl #37166)
  3. add novel_crime_midnight, and three new swashbuckling books
  4. add a few more fairy snippets
  5. add paperback_occult abstract
  6. add occult_economicon, occult_bobliographon, and occult_glimpses
  7. add three romance paperback abstracts, each representing a publisher of romance novels
  8. ten new romance novels
  9. add a western abstract and six books copying from it
  10. add holybook abstract and associate holy books with it
  11. move holybook abstract and associated holy books into their own file: spiritual.json
  12. add a dodge abstract and new mid-level dodge book
  13. added 5 new satires: The House of God, Catch-22, Master and Margarita, Cat's Cradle, and a Handful of Dust
  14. create tables for magazines including SUS_book_nonf_zine
  15. add hard back archery abstract
  16. add 8 "homemaking" books in a file called nonfiction.json, where further nonfiction clutter will go. Add additional nonfiction clutter to same file, including a number of books about psychology that I hope can add some creepiness to labs and mansions.
  17. add a new speech book "Nail Your Law Firm Interview"
  18. move some kids books from misc to a new file young.json, and add a number of young adult books (fiction clutter) to same file
  19. add romances and westerns to SUS_fiction_bookcase in SUS/library.json
  20. add a "cascading" set of tables to SUS/library.json, each returning a single book with greater degrees of specificity
  21. add 4 new pulp fiction novels
  22. move abstracts to abstract.json

Describe alternatives you've considered

occult books added to misc

I added two "occult paperbacks" on the Church of Subgenius. Church of Subgenius is an existing entity within CDDA, and the books are loyal to that faith tradition, meaning that they are inherently nonsensical in nature.

The third paperback references The Church of Starry Wisdom, and I didn't want to compromise existing lore; so this book is purposefully portrayed as an unreliable source of info.

added new file spiritual.json

spiritual.json could perhaps be better named holy.json or inspirational.json. The former due to the subject matter, naming convention, and presumably intent. The later due to the flag. "Spiritual" is useful because of the trait.

OC vs IRL

I added fiction books that were of my own made creations, and I also added famous real novels. The file already included dozens (hundreds?) of titles of real novels. Do we have a preference for real world content vs OC? Is having a mix of both problematic?

Organization

I organized content first as fiction or nonfiction, and then by type (paperback or hardback mostly, but there are others printed materials too).

This was only semi-intentional, and stems from the convention that skill training books tended to be nonfiction and hard backs, whereas non-skill books (ie., books for fun, clutter books, books for lore) tended to be fiction and have physical stats suggesting paperback. Regardless of the merits of one taxonomy decision vs another, it is better to have content organized than not. I'm not wedded to my scheme, but I do wish to continue to organize this content so that it is convenient.

I hope to add at least a dozen hardback fiction books for variety. These will take up significantly more inventory space. However this PR does not include that. Additionally, I hope to add dozens of nonfiction titles that are not skill books. This PR does not include those.

The homemaking category might be a tad sexist. These are books about gardening, beauty, entertaining, and home decor. It isn't visible in game however, and I don't want to further complicate this request.

library.json

The extensive "cascading" set of tables added to SUS/library.json violates the letter of that project, but conforms to the spirit of it. The single tables are not meant to reflect a specific piece of furniture, and are meant to facilitate that admirable goal.

misc

Some things I wanted to do but resisted the impulse:

  • Dungeon Masters Guide has a bashing of 7, more than a metal pot, and over twice as deadly as a steel ladle or a can opener. I considered bringing it down to at least 6.
  • Considered change priest_diary from fun: -1 to fun: 1
  • Considered change read time of story_book - it currently has 28 chapters and each one takes nearly an hour to read; what kind of short stories are these?

Testing

  • I used a relative on novel_satire and so I tested that price was in fact 850 (750+100)
  • used relative on novel_swash_searovers and tested that weight was 557 (1.2lbs) and there were 24 quickly read chapters of fun 2 each
  • check that novel_swash_blkfreight had fun 4 and only 8 chapters
  • ensure game loads
  • use "Test Item Group" debug tool to test item spawns, particularly SUS_fiction_bookcase, which favors fiction genres that have not been updated
  • double check that item_groups and abstracts allow for nested relationships more than one deep
  • Holy books all draw from one abstract with two materials: paper and cardboard. Test how this impacts scrap/deconstruct/butcher.
TODO
  • Cat's Cradle (book_fict_soft_satire_cats) has 127 chapters. Each one should take 1m to read (maybe 2m?) and provide 1 fun (because there is nothing lower)
  • test that fantasy novels now look (merely have the tile) like dungeon master guide
  • test that skill: foo overrides chapter setting

Additional context

I tangled up my master branch, so there are some unrelated files here. It doesn't look like anything problematic and it is unintentional.

"Buzzards Bay" with no apostrophe is not a typo; BB is off the coast of Rhode Island and Mass and I triple checked the spelling.

I could not get the time parameter to function correctly as a relative value. A guess is this might be a fault of the abstract uses a string and my instance used an integer? I side stepped this by just taking it out of the relative (defining it explicitly).

While I was looking into giving occult books INSPIRATIONAL flags I discovered that Spiritual is multiplicative, but nearly every book flagged has fun 1 so that is irrelevant. The priest_diary has fun: -1, meaning that a Spiritual character will find priest diary three times as boring as a non Spiritual character - clearly a bug. This should be addressed, but is outside the ever-expanding scope of this PR.

Future plans

Once I've added a greater variety of books, I intend to take a look at book stores and libraries to see if I can improve those locations with both more and better organized books.

@I-am-Erk I-am-Erk added 0.E content freeze [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 25, 2020
@Jerimee Jerimee changed the title More paperbacks [WIP] More paperbacks Jan 25, 2020
Jerimee added 8 commits April 14, 2020 18:04
move items/classes/book.json to items/book/abstract.json
changes times to strings and other misc typos
move book abstracts over that were previously in folder classes
fix nonfiction to conform to string (time: 20 m NOT time: 20)
FIX MISTAKE: this pr shouldn't alter bashing.json
add abstracts to cooking
@Jerimee Jerimee changed the title [WIP] Lots more books Lots more books May 6, 2020
@Jerimee
Copy link
Contributor Author

Jerimee commented May 6, 2020

This PR has become unwieldy - can be merged as is?

If not, I think I need to close it and then break it down into distinct parts so that it is easier to discuss, test, and merge.

The impact in-game will be that there are more clutter paperback books, particularly in those spawning from SUS itemgroups.

The bigger impact is the changes to the organization and taxonomy for book json and SUS library. Hopefully what I've done here makes the desired organization clear.

update spiritual.json in the hopes that clang-tidy will take pity on me
@ZhilkinSerg
Copy link
Contributor

We just need to fix some minor formatting issues reported in (double spaces and such). Can be handled while mergetesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants