Fix unmountable turret bug #39552
Merged
Fix unmountable turret bug #39552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug preventing turrets from being mounted by players. I only found the bug's location, Korg provided the code.
add whitespace
ZhilkinSerg
added
<Bugfix>
ZhilkinSerg
reviewed
Apr 14, 2020
|
Sorry, I have very little idea of what Travis/CI does or why it's angry, will have to figure that out in the morning. I also don't know how to attach labels and apologize for that additional overhead. |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Players unable to mount turrets on vehicles."
Purpose of change
Fixes #39436
Describe the solution
Very small change to item::allow_crafting_component(); prior to fix it was incorrectly registering guns themselves as contained objects, preventing eligibility for mounting.
Describe alternatives you've considered
None, I want to play with my new ballista.
Testing
Additional context
I only found the bug's location, Korg provided the code.