Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more plastic items to the plastic chunk recipe and consolidate recipes #39460

Merged
merged 7 commits into from
Apr 14, 2020
Merged

Added more plastic items to the plastic chunk recipe and consolidate recipes #39460

merged 7 commits into from
Apr 14, 2020

Conversation

friendfrog
Copy link
Contributor

@friendfrog friendfrog commented Apr 11, 2020

Summary

SUMMARY: Content "Add more plastic items to the plastic chunk recipe."

Purpose of change

I wanted to be able to melt down plastic cutlery into chunks, I also found a few other plastic items and added them to the recipe as components as well. There's certainly better ways to get plastic chunks but I like immersion.

Describe the solution

JSON editing

Describe alternatives you've considered

Giving up

Testing

Spawned in all the items and made a lot of plastic chunks.

Additional context

@friendfrog friendfrog changed the title Added more plastic items to the plastic chunk recipe Added more plastic items to the plastic chunk recipe and consolidate recipes Apr 11, 2020
Comment on lines -3397 to -3399
"type": "recipe",
"result": "plastic_chunk",
"id_suffix": "from_cash_cards",
Copy link

@ghost ghost Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to recipes/recipe_obsolete.json as well or this will cause load errors:

{
  "type": "recipe",
  "result": "plastic_chunk",
  "id_suffix": "from_cash_cards",
  "obsolete": true
}

@friendfrog friendfrog marked this pull request as ready for review April 11, 2020 01:41
@Pupsi-Mupsi
Copy link
Contributor

Pupsi-Mupsi commented Apr 11, 2020

Would you change you summary:
SUMMARY: Content "Add more plastic items to the plastic chunk recipe."

@Pupsi-Mupsi
Copy link
Contributor

Pupsi-Mupsi commented Apr 11, 2020

You actually need to add all of it for a valid PR, otherwise the "PR Validator / Validate PR (pull_request) " won't be valid.

SUMMARY: Content "Add more plastic items to the plastic chunk recipe."

Like this:
grafik

@ZhilkinSerg ZhilkinSerg added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Apr 14, 2020
@ZhilkinSerg ZhilkinSerg merged commit 6a0f406 into CleverRaven:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants