Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update armor.json #39615

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Update armor.json #39615

merged 1 commit into from
Apr 17, 2020

Conversation

Arcangelus
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fix obvious typo, allowing the item "hologram cloak mk.2" to not be blocked by anatomy.

Describe the solution

Corrected flag from "OVERSIZEs" to "OVERSIZE".

Testing

No errors.

Additional context

I stumbled upon this while looking for something unrelated. I'm surprised that the game doesn't trow errors when an invalid flag is used.
The item's description also looks fishy, but I'm unsure as to what was supposed to say.

Fixed typo
@anothersimulacrum
Copy link
Member

There's no canonical list of existing flags (for items, other things have this), so it makes it very hard to error check.
Additionally, some flags can be defined and have functionality entirely in JSON, which further complicates this.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod labels Apr 17, 2020
@ZhilkinSerg ZhilkinSerg merged commit 6c28dd3 into CleverRaven:master Apr 17, 2020
@Arcangelus Arcangelus deleted the patch-1 branch April 20, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants