Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazemod re-work preparatory restructure #39621

Conversation

Soup-de-Loop
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Restructures blazemod file structure"

Purpose of change

Simply re-organises blazemod's file structure to reflect modern vanilla standards for ease of use and better sorting, in preparation for initial re-work to begin actual changes.

Describe the solution

Added actual sub-folders to help organise json to reflect vanilla file structure, and separated out distinctive sub-categories of content groupings (i.e. normal, blob, diamond, vortex etc). This makes it far easier to address issues or modify content, and to make it easier to find what is actually changed by the rework since most of the line changes are actually this re-organisation. 5000+ was too much to skim inbetween for real changes.

Describe alternatives you've considered

Forcing other contributors to review the re-work as-is, which isn't suitable for anyone and more work than necessary when I can just do this first. The re-work shall be rebased, making is far easier to read actual changes.

Testing

No testing as nothing is changed beyond filestructure and all current issues remain as-is, to be addressed in the re-work.

Additional context

Re-work just recently went out of draft status to a full-fledged PR, which is #37497

No entries deleted or edited, only file restructuring
@sayke
Copy link
Contributor

sayke commented Apr 17, 2020

You rule. Thank you for taking on Blazemod!

@Soup-de-Loop Soup-de-Loop marked this pull request as ready for review April 17, 2020 05:29
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Apr 17, 2020
@ZhilkinSerg ZhilkinSerg merged commit 5748d3f into CleverRaven:master Apr 17, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Apr 17, 2020
10 tasks
@Soup-de-Loop Soup-de-Loop deleted the soup-de-loop-blazemod-file-refactor branch April 30, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants