Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read times set via relative are ignored #39570

Closed
Jerimee opened this issue Apr 14, 2020 · 2 comments
Closed

Read times set via relative are ignored #39570

Jerimee opened this issue Apr 14, 2020 · 2 comments
Labels
Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Jerimee
Copy link
Contributor

Jerimee commented Apr 14, 2020

Book time parameters set via relative in an object that uses copy-from: abstract are ignored entirely. The top level abstract time value is the time value for all descendants, unless a time value is set outside of relative.

Steps To Reproduce

Put the following file in the book directory, load game, wish yourself Book A, Book B, Book C, and/or Book D and see that read times set via relative are not impacted.

testDONOTPUB.zip

Expected behavior

Ideally the read time would be increase or decreased via relative as other parameters are. If the string notation "time": "20 m" is preferable to the integer "time": 20, then the string should be used within the relative too - the code should parse both string and integer in the same way.

Additional context

This is a feature request if abstract inheritance via relative was not meant to support time.

See #37377 for discussion (I could not get the time parameter to function correctly as a relative value. A guess is this might be a fault of the abstract uses a string and my instance used an integer? I side stepped this by just taking it out of the relative (defining it explicitly).)

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 15, 2020
@Jerimee
Copy link
Contributor Author

Jerimee commented May 7, 2020

Probably not very helpful, but just in case...

Anothersimulacrum informed me today that

There's no support for relative and the like for units::length
Game doesn't know what to do with it

@Jerimee
Copy link
Contributor Author

Jerimee commented May 23, 2020

chapters doesn't seem to be modified by relative either

"relative": { "chapters": -2 }

the above will just be ignored...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

2 participants