new char popup edit boxes #39467
Merged
new char popup edit boxes #39467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Enhancement / Feature>
Qrox
reviewed
Apr 11, 2020
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Qrox
reviewed
Apr 11, 2020
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Uses string popup menus for name, age, and height in character creation"Purpose of change
Fixes #39411
Also changes the randomizer to randomize all values on the page (description)
Describe the solution
uses string_init_popup instead of checking each keystroke for a key and then using that to enter in a name. honestly i think it looks a lot cleaner in code, even if it adds a couple button presses to character creation.
I changed around the location of some of the catacurses windows to make the "press confirm to edit" show below the "name" field
Testing