Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cave jsonify #39610

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Cave jsonify #39610

merged 2 commits into from
Apr 17, 2020

Conversation

Night-Pryanik
Copy link

Summary

SUMMARY: Content "Cave jsonify."

Purpose of change

Jsonify and make cave location more interesting.

Hardcoded cave location was boring and uninteresting as hell, both from atmosphere and gameplay point of view. There was almost no reason to delve into the caves.
Initially I just wanted to jsonify the mapgen and call it a day, but eventually decided to rework location to be more fun and interesting. I'm not saying that now caves are THAT interesting, but at least they are more interesting than previous squares of cave floor with almost no loot and design.

Describe the solution

  • Added several above-ground and underground variants and made them spawn in the world. Above-ground variants all have the same chance to spawn. They aren't differ that much - there are "bats", "spiders", "cougars", "bear" and some other variants with similar layout.
    Underground variants differ heavily, with the "trash and monster parts" variant being the most common. There are also "archeology site", "cave minerals and broken molebots", "survivor's hideout", "giant naked molerats" and some other variants with lower chance to spawn.
  • Caves now spawn only in forests rather than almost everywhere, and at least 5 distance from cities. This change makes them spawn rather rarer than before.
  • Removed hardcoded mapgen.

Describe alternatives you've considered

None.

Testing

Teleported around the map, found several caves, searched through them.

Additional context

Some of above-ground variants:
изображение

изображение

изображение

Some of underground variants:
изображение

изображение

изображение

изображение

изображение

@Night-Pryanik Night-Pryanik added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` labels Apr 16, 2020
@ZhilkinSerg ZhilkinSerg merged commit 086d751 into CleverRaven:master Apr 17, 2020
@Night-Pryanik Night-Pryanik deleted the cave-jsonify branch April 17, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants