Use correct sh syntax for string comparison #39619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: nonePurpose of change
To make the
lang/compile_mo.shscript compatible with its interpreterWithout this, I was getting the following syntax error every time I ran the script:
lang/compile_mo.sh: 27: [: es_ES: unexpected operatorDescribe the solution
Change the equality comparison to use
=instead of==(which is not available inshor indashwhich is the default system shell in Ubuntu).Testing
Script runs without syntax errors
Additional Context
https://stackoverflow.com/questions/10849297/compare-a-string-using-sh-shell
On Ubuntu,
dashhas been the default system interpreter since version 6.10 (released in 2006).