Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modularvest items #36920

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Remove modularvest items #36920

merged 1 commit into from
Apr 17, 2020

Conversation

ymber
Copy link
Member

@ymber ymber commented Jan 11, 2020

Summary

SUMMARY: Content "Remove MBR vests"

Purpose of change

MBR vests were a relic of old cata with inconsistent behavior and no discernible basis. They're being replaced with real plates and carriers.

Describe the solution

Remove modularvest* items. Replace with other items where appropriate.

Testing

Game loads correctly without errors.

Additional context

We may want to add survivor made hard steel plates and stab panels.

@Brian-Otten
Copy link
Contributor

This sounds like a great idea but should probably wait for the real plates and plate carriers to be ready, so we can swap them in to replace the mbr variants (everywhere if appropriate). I don't see how removing mbr vests from the game before them helps us much.

@SirPendrak
Copy link
Contributor

SirPendrak commented Jan 11, 2020

"Kevlar slot" in survivor recipes had MBR before, now it has ballistic vest empty. But does it contain any kevlar at all?

Why remove it completly right now, even if theese things wont spawn naturally anymore, maybe keep the recipes? They dont seem Scifi or harder to make than other recipes we already have, and they offer good variety for survivors that manage to gather varoius materials for their first serious armor. And their ballance PR is already on Github

@Brian-Otten
Copy link
Contributor

Keep this in in the pocket though, when we have the plate carrier system with plates fully ready this should almost definitely happen. Should cause no loss of functionality then and improve the gamefeel.

@tenmillimaster
Copy link
Member

"Kevlar slot" in survivor recipes had MBR before, now it has ballistic vest empty. But does it contain any kevlar at all?

Functionally speaking, an MBR and an empty ballistic vest(insert-less SPCS or similar, all the way back to interceptor era armor likely) are identical. The empty ballistic vest could be disassembled further to remove its soft armor inserts.

@tenmillimaster
Copy link
Member

tenmillimaster commented Jan 11, 2020

I recommend just going ahead and replacing the MBR variants with ballistic vest variants.

Kevlar insert, Bookplate, Aluminum sheet, Titanium panels, steel plating and commercial AR500 Hardsteel plating (hard plating item is sufficiently similar, as many industrial applications use similar Abrasion Resistant steels) would all be valid options. The hard plates are both found as steel targets at shooting ranges and also sold as vest inserts.

  • Hard plating would be the only one you'd encounter in the wild, however, (not in military service).
  • Bookplate would offer some mitigation to rounds that penetrate vests. (https://www.theboxotruth.com/the-box-o-truth-31-the-books-o-truth/)
  • Kevlar inserts are used sometimes as an alternative to spall liners found on plates. They would increase protection if used alone on a vest.
  • Aluminum, Titanium, and mild steel would all provide little protection (to varying degrees) but would absolutely increase the vest's performance.

I also recommend, either here or at a later date, relegating the MBR items to a Post-cataclysm Survivor fabrication. In this sense, it'd be the sewing of front, back, and side pockets to accept ballistic inserts onto a kevlar vest, to increase its protection.

@Ker-Nes
Copy link
Contributor

Ker-Nes commented Jan 11, 2020

I'm against it. A rename might be good, but the MBR is a good option to represent overt bullet resistant vests with plate holders. While the ballistic vest is a good option to represent actual plate carriers (which aren't bullet resistant on their own), there are such things as the aforementioned overt vests, such as this one: https://www.marsarmor.com/products/ballistic-vests/overt/model-25/ and multiple others.

Edit: Of particular note of the same brand even:
https://www.marsarmor.com/products/ballistic-vests/military/model-76/
https://www.marsarmor.com/products/ballistic-vests/military/model-75/

Which I see basically as exactly what the MBR vest in the game is supposed to represent (or evolutions of such).

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 12, 2020
@kevingranade
Copy link
Member

This is pretty impactful, so I want to take it a little slow.

  1. Add the new ballistic vests and spawns, remove spawns of old vests.
  2. Let it sit for a while and make sure nothing is breaking.
  3. Migrate existing MBRs to the equivalent ballistic vest.

@Inglonias
Copy link
Contributor

I'm still concerned about the absurdly high armor values of the new ESAPI vests. Are we sure that those are in line with reality? They seem extraordinarily powerful, especially if compared to other armor in the game.

@SirPendrak
Copy link
Contributor

SirPendrak commented Jan 14, 2020

Lets increase armor of every zombie soldier type to 50b 90c to match ballistic vest almost every one zsoldier wears.

On serious side, someone made seriously wrong assumption that IRL behavior of stopping most 7,62 rifle rounds translates to 0 dmg at our current damage system. Armor values of old Hardsteel MBR pictured it better.

@Inglonias
Copy link
Contributor

It looks like the main issue is that we can't actually define those values directly. They are derived from material thickness, and with a material thickness of 20, the ESAPI plates just break the armor and damage system. It may be worth looking at how those get calculated before we replace the MBRs with these new vests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants