Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuji's military profesions still use MBR vests #44207

Closed
Comrade-Soupbeans opened this issue Sep 16, 2020 · 1 comment · Fixed by #44251 or #51833
Closed

Fuji's military profesions still use MBR vests #44207

Comrade-Soupbeans opened this issue Sep 16, 2020 · 1 comment · Fixed by #44251 or #51833
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON

Comments

@Comrade-Soupbeans
Copy link
Contributor

Describe the bug

MBR vests were removed by #36920 but the Fuji professions never got updated leading to an error where mags are put into non-existent items (see additional context)

Steps To Reproduce

Make a world with Fuji's professions and hover over one of them such as military rifleman

Expected behavior

That these professions would have been updated along with the vanilla ones

Screenshots

Versions and configuration

Experimental tiles version 11006 downloaded by launcher
Windows 10 64-bit

Additional context

DEBUG : tried to put an item (stanag30) count (1) in a container (modularvestceramic) that cannot contain it: pocket with type (CONTAINER) not found

FUNCTION : ret_val item::put_in(const item&, item_pocket::pocket_type)
FILE : src/item.cpp
LINE : 1102

and

DEBUG : tried to put an item (mp5mag) count (1) in a container (modularvestkevlar) that cannot contain it: pocket with type (CONTAINER) not found

FUNCTION : ret_val item::put_in(const item&, item_pocket::pocket_type)
FILE : src/item.cpp
LINE : 1102

@Maleclypse
Copy link
Member

I’ll try and fix this

@anothersimulacrum anothersimulacrum added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor labels Sep 17, 2020
Rivet-the-Zombie added a commit that referenced this issue Sep 24, 2021
[Fuji_Mil_Prof] Removes Lingering MBRs and Further Fixes #44207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON
Projects
None yet
3 participants