Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming a mutation into another on activation #39523

Merged
merged 14 commits into from
Apr 17, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Apr 13, 2020

Summary

SUMMARY: Infrastructure "Transforming a mutation into another on activation"

Purpose of change

Add a system similar to transform use action of items, which should make jsonizing mutations a lot easier.

Describe the solution

Add mut_transform struct
Upon activation a mutation with a transform entry is unset and it's transform target is set instead

Set up "CLAWS_RETRACT" to use this system
Jsonize pierceing damage and butchering quality
Get rid of NEED_ACTIVE_TO_MELEE flag that is not usefull anymore

Describe alternatives you've considered

Testing

Get retractable claw mutation
Fight a Z
Do little damage
Activate it
Attack Z and do more damage

Additional context

@Fris0uman Fris0uman marked this pull request as ready for review April 13, 2020 14:10
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Apr 16, 2020
@ZhilkinSerg ZhilkinSerg merged commit af60511 into CleverRaven:master Apr 17, 2020
@Fris0uman Fris0uman deleted the activate_mut branch April 17, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants