[Aftershock] Frankenstein NPCs #37908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs Cyrus Whately NPC, needs Millyficent to create mission to meet him that adds mapgen. Cyrus Questlines.
ghost
reviewed
Feb 11, 2020
John-Candlebury
added
0.E Content Freeze
Crafting / Construction / Recipes
This was referenced Feb 16, 2020
Update my fork
Post 0.E merge fest
Update repo
Update to pockets
This reverts commit 73a51fb.
|
@ZhilkinSerg hate to bother you but I'm trying to make use of the iuse function you added in #36358 and when I test it, it doesn't work and sometimes it says no room to place NPC, but sometimes it silently fails. Is it something wrong with how I'm using it or any ideas? Thanks whenever you get a chance to look at this I appreciate it. |
|
Something is wrong with random placement. Non-random seems to be working. |
Thanks I'll just set that to false then. :) |
Maleclypse
changed the title
Merged
|
Travis CI error seems unrelated to my changes. It loads fine on my test bed and I can play through the missions. |
ZhilkinSerg
reviewed
Aug 3, 2020
data/mods/Aftershock/npcs/Backgrounds/talk_cyborg_abomination.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Frakenstein NPCs"
Purpose of change
Adds uses for mi-go bioparts that are salvageable.
Describe the solution
Create's book, items, NPC class. Cyrus Whately NPC, Millyficent to create mission to meet him that adds mapgen. Cyrus Questlines. Background traits and storys for the revivees. Created additinonal terrain for overhead lights. NPCs in Whately LMOE.
Things to do beyond the scope of this PR: Need to give Cyrus Whately more dialogue. Need to create more static NPCs to place at Millyficent's. Move new overhead light terrains to mainline. Give Cousins more dialogue. Is it possible to give Cousins different NPC needs? Can the faction trust feature be used to eventually allow the PC to recruit Whately Cousins found in the wild?
Describe alternatives you've considered
none
Testing
Extensive testing at various stages.
Additional context
TBD