Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] forgotten experiment #44709

Merged
merged 40 commits into from
Nov 2, 2020
Merged

[Aftershock] forgotten experiment #44709

merged 40 commits into from
Nov 2, 2020

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Oct 8, 2020

Summary

SUMMARY: Mods "Adds unique NPC 'Sadie', a forgotten experiment"

Purpose of change

Build on Whately storyline, powerful follower, make world feel more fleshed out

Describe the solution

New NPC class "forgotten experiment" for Sadie with medical mutant and cyborg traits and items that make some sense for her. Dialog establishing what she knows of who she is, a fetch quest for a new heart, and an intrusive medical service. Bugfix for Wilhemina and Nicodemus dialogue. Bugfix for Cyrus Alpha mission. Bugfix for Cyrus broken cyborg mission. New large storage unit variant that spawns Sadie's nested mapgen. Player can ask Sadie what she thinks of her location using the background talk system and she has some special dialog for some overmap locations and can tell if she's at a safe place or not.

Describe alternatives you've considered

Just use an existing class. New missions and effects specific to building locations kicked off by dialog while following. Connection to existing Whately storyline.

Testing

Game loads, no errors

Stumbled into Nicodemus and Wilhemina bugs in testing
Screen Shot 2020-10-12 at 8 23 45 AM

Tested them fixed
Screen Shot 2020-10-12 at 9 09 18 AM

Hacking Sadie into existence works, she offers a mission

Screen Shot 2020-10-26 at 9 51 19 PM

The mission spawns Billy as expected

Screen Shot 2020-10-26 at 9 56 35 PM

Sadie can spawn in large storage units (older image, she doesn't have that gear now)

image

Sadie's injection works

image

Additional context

Inspired by #37908 and the album Frankenstein Girls Will Seem Strangely Sexy

@LyleSY LyleSY added Mods: Aftershock Anything to do with the Aftershock mod NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON labels Oct 8, 2020
@LyleSY LyleSY added the <Bugfix> This is a fix for a bug (or closes open issue) label Oct 12, 2020
@LyleSY
Copy link
Contributor Author

LyleSY commented Oct 27, 2020

weary_test.cpp failure doesn't appear to be related

@LyleSY LyleSY changed the title [WIP] [Aftershock] forgotten experiment [Aftershock] forgotten experiment Oct 28, 2020
@LyleSY LyleSY marked this pull request as ready for review October 28, 2020 01:10
@John-Candlebury
Copy link
Member

John-Candlebury commented Oct 28, 2020

I'll ask @Maleclypse to review this one becuase the more horror inspired segments of Aftershock are more his part.

Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. Thank you so much for the work on this!

data/mods/Aftershock/npcs/sadie.json Outdated Show resolved Hide resolved
@LyleSY
Copy link
Contributor Author

LyleSY commented Oct 30, 2020

Travis error doesn't look related

@ZhilkinSerg ZhilkinSerg merged commit 97896c2 into CleverRaven:master Nov 2, 2020
@LyleSY LyleSY deleted the patch-4 branch November 3, 2020 01:45
@Salty-Panda
Copy link
Contributor

I'm unable to make her give me another injection.
After recruiting the option has never appeared.
I successfully completed her mission and received the first one properly.

@GyprockGypsy
Copy link

Just encountered this character. and was really interested by her story line, but she sent me to a monster that only produced putrid hearts, and which she wont accept.

@Salty-Panda
Copy link
Contributor

Just encountered this character. and was really interested by her story line, but she sent me to a monster that only produced putrid hearts, and which she wont accept.

You need to make a full butchery or field dress, not dissection
image

@GyprockGypsy
Copy link

GyprockGypsy commented Jan 10, 2021

That's not an issue. I just finished reading Bio of a Mountain Man after a bad lab run, and I scummed this spot to try to figure it out., I got the putrid hearts from "Billy" like she wanted, she just wont accept them. I've tried obtaining the hearts through Field Dressing, Full Butchery, and Dissection, and this even clears that stage of the quest marker, but I do not get quest to return to her, and she wont recognize that they are in my inventory. I've also tried doing this with and without the assistance of an NPC.

Win 10
Build 11352
Mods: Aftershock, CRIT, Dino, Magic, Crazy, Map Graphics, Undead People Compatibility Mods

@Salty-Panda
Copy link
Contributor

That's not an issue. I just finished reading Bio of a Mountain Man after a bad lab run, and I scummed this spot to try to figure it out., I got the putrid hearts from "Billy" like she wanted, she just wont accept them. I've tried obtaining the hearts through Field Dressing, Full Butchery, and Dissection, and this even clears that stage of the quest marker, but I do not get quest to return to her, and she wont recognize that they are in my inventory. I've also tried doing this with and without the assistance of an NPC.

Win 10
Build 11352
Mods: Aftershock, CRIT, Dino, Magic, Crazy, Map Graphics, Undead People Compatibility Mods

You should obtain this item:
image
Report a bug, probably something changed

@GyprockGypsy
Copy link

Ya, she sent me after a Jabberwock, not a Flesh Golem. Will make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants