Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix place npc iuse #42647

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fix place npc iuse"

Purpose of change

Follow-up after #36358.

Describe the solution

Fixed logic in calculating npc placement target point.

Testing

  1. Use following iuse actions on any two items to test npc placement via iuse function:
    "use_action": [{
        
        "type": "place_npc", 
        "npc_class_id": "true_foodperson", 
        "summon_msg": "You summon a food hero (random)!",
        "place_randomly": true, 
        "moves": 50
    }]
    "use_action": [{
        
        "type": "place_npc", 
        "npc_class_id": "true_foodperson", 
        "summon_msg": "You summon a food hero (direction)!",
        "place_randomly": false, 
        "moves": 50
    }]

Additional context

#37908 (comment)
#36358 (comment)

@ZhilkinSerg ZhilkinSerg added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) [Markdown] Markdown issues and PRs labels Aug 2, 2020
doc/JSON_INFO.md Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 9ffafff into CleverRaven:master Aug 3, 2020
@ZhilkinSerg ZhilkinSerg deleted the fix-iuse-place-npc branch August 3, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items / Item Actions / Item Qualities Items and how they work and interact [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants