Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added batch time saving for all sugar recipes #36959

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Jan 12, 2020

Summary

SUMMARY: Content "added batch time saving of 80% > 1 unit for sugar recipes"

Purpose of change

IRL sugar cooking in batch would bring significant time saving, that should be reflected in the game too.

Describe the solution

Added batch saving 80% > 1 unit for all 3 sugar recipes without saving.
Updated sweet water > sugar recipe batch saving from 50% > 4 to 50% > 1.

Testing

not tested.

@mlangsdorf mlangsdorf added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jan 12, 2020
@Brian-Otten
Copy link
Contributor

Sounds good to me. if you want this to be more certain to merge/ merge quicker load up your game with this real quick and show what the new crafting times are for batches of 20 compared to making 1. Always good to doublecheck if everything is working as intended.

@mkikt4743
Copy link

should be a bit slower per batch I think

@I-am-Erk
Copy link
Member

I don't think batching saves as much time as you imagine here. These processes all appear to rely on boiling off the water, which is going to take longer the more water you have unless you change equipment to have a wider surface area. I'd be surprised if you could save 10% time

@@ -3693,6 +3693,7 @@
"time": "24 m",
"charges": 10,
"autolearn": true,
"batch_time_factors": [ 80, 1 ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment: these batch time factors are way way too efficient.

@8ctopus
Copy link
Contributor Author

8ctopus commented Jan 27, 2020

I just returned home, I'll revert shortly.

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 10, 2020

Thank you everyone for the feedback provided.

I've updated all sugar recipes to save 20% time for batches instead of the original 80% gain.

It's true that boiling twice the amount of water will take double the time, however as @I-am-Erk suggested, there can still be gains by increasing the contact surface or increasing the surface temperature (my guess).

It's also an option to ignore this merge request, however completely dropping the speed gains would make the recipes not used much in practice because they take way too long.

@8ctopus 8ctopus requested a review from I-am-Erk February 17, 2020 05:10
@kevingranade kevingranade merged commit 9dcb880 into CleverRaven:master Apr 2, 2020
@8ctopus 8ctopus deleted the batch-time-factors-sugar branch April 3, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants