Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Remove attached part first.' message displays the part name #37922

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Feb 11, 2020

Summary

SUMMARY: Interface "'Remove attached part first.' message displays the part name"

Purpose of change

Fixes #37918

Describe the solution

Insert %s in the message. Get the part name. Format the reason string.
screen

Describe alternatives you've considered

Show it like this: "Remove attached %s first."

Testing

Compiled fine. It shows the translated security system part name.

Additional context

It makes sense to show the part name in some other cases too. There are more than one seatbelt types.

@jkraybill
Copy link
Contributor

Less than 30 minutes from the submitted issue. Thanks!!

@Hirmuolio
Copy link
Contributor

Hirmuolio commented Feb 11, 2020

#37453 also adds this to all parts. It uses a blanked "Remove attached [part]" on all parts.

@AMurkin
Copy link
Contributor Author

AMurkin commented Feb 11, 2020

This can be merged in the mean time, I think. To reduce the difference I can change the message to match yours.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions labels Feb 11, 2020
@ZhilkinSerg ZhilkinSerg merged commit b75d7db into CleverRaven:master Feb 11, 2020
@AMurkin AMurkin deleted the expose-attached-part branch February 13, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Remove attached part first" message should display attached part
4 participants